Add rootfs tests - #1498
Merged
Merged
Add rootfs tests#1498
Conversation
ValentaTomas
force-pushed
the
rootfs-test
branch
from
November 18, 2025 07:44
39b46b1 to
1b8a7ad
Compare
ValentaTomas
force-pushed
the
rootfs-test
branch
from
November 18, 2025 08:28
1b8a7ad to
b94dbaf
Compare
ValentaTomas
marked this pull request as ready for review
November 19, 2025 03:56
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
Merging to the other PR after tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to change the tests to run as root, because NBD requires that.
I also added -race in the unit tests—will remove and re-add it in another PR if it is problematic here to quickly merge the hotfix.
More tests for the NBD should follow in next PR too.
Note
Adds NBD direct-path tests with new test utilities, enhances mount-rootfs (empty/verify/log), enables NBD and root-permission tests in CI, and removes legacy mock-nbd.
nbddirect-path read/write tests (incl. O_DIRECT and large dd) ininternal/sandbox/nbd/path_direct_test.go.internal/sandbox/nbd/testutils/*(ZeroDevice,BuildDevice, NBD device/mount helpers, cleaner, logger overlay, template rootfs helper).cmd/mount-rootfswith flags:-empty,-size,-block-size,-verify,-log; supports creating empty rootfs, integrity/journal verification, and structured logging.start.shto pass through args.modprobe nbd), add udev rule to disable inotify onnbd*, and rungo testwithsudoin PR workflow.cmd/mock-nbd/andmock-nbdMakefile target; dropgithub.com/pojntfx/go-nbddependency.DiffStore.RemoveCache()for cleanup; minor header comment tweak.Written by Cursor Bugbot for commit da8c36d. This will update automatically on new commits. Configure here.