fix: install the avahi .deb non-interactively past the conffile prompt - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6. Now that the avahi_0.8 .deb installs over stock avahi (Replaces), the full image build hit the next wall: dpkg raised an interactive conffile prompt on
/etc/avahi/avahi-daemon.confand aborted.The base RPi OS image ships an RPi-modified
avahi-daemon.conf, and the .deb ships its own copy as a conffile, so dpkg wants a decision.DEBIAN_FRONTEND=noninteractivedoes not cover dpkg's own conffile prompt (that needs--force-conf*), so with no stdin the install died. #6'sset -euo pipefailcorrectly turned this into a hard build failure instead of a silently broken image.The
verify-installgate in avahi_0.8 and this workflow both missed it because they installed over a pristine stock conf, which produces no prompt.customize.sh: install with-o Dpkg::Options::=--force-confdef -o Dpkg::Options::=--force-confold. Keep the base config (the 5358 patch is in the binary/lib, not the conf).validate.yml: append a line to/etc/avahi/avahi-daemon.confbefore runningcustomize.sh, so CI reproduces the modified-conffile prompt, not just the file-overwrite conflict.