Skip to content

Fix missing encoding of project names in urls - #1438

Merged
tmat merged 6 commits into
dotnet:mainfrom
mbxsuite:main
Jul 9, 2025
Merged

Fix missing encoding of project names in urls#1438
tmat merged 6 commits into
dotnet:mainfrom
mbxsuite:main

Conversation

@mbxsuite

Copy link
Copy Markdown
Contributor

Fixes missing urlencoding of project names in scm urls of Azure Devops Server.

Nuget meta data originally containes a SCM URL path "collection/project%20name/repo", which got turned into "collection/project name/repo", thus later on breaking sbom validation of package.

#706

@mbxsuite
mbxsuite requested review from ViktorHofer and tmat as code owners May 21, 2025 13:27
@ViktorHofer
ViktorHofer removed their request for review May 21, 2025 13:41

@tmat tmat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test

@mbxsuite

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@mbxsuite
mbxsuite requested a review from tmat May 22, 2025 15:09
@ViktorHofer

Copy link
Copy Markdown
Member

@tmat PTAL - tests got added

@tmat
tmat merged commit 57e04d5 into dotnet:main Jul 9, 2025
@tmat

tmat commented Jul 9, 2025

Copy link
Copy Markdown
Member

@mbxsuite Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants