Skip to content

Increase SDL pipeline job timeout - #56140

Open
nagilson wants to merge 2 commits into
dotnet:mainfrom
nagilson:users/nagilson/sdl-timeout-90
Open

Increase SDL pipeline job timeout#56140
nagilson wants to merge 2 commits into
dotnet:mainfrom
nagilson:users/nagilson/sdl-timeout-90

Conversation

@nagilson

@nagilson nagilson commented Sep 4, 2026

Copy link
Copy Markdown
Member

I made the pipeline in AzDo.

But, https://dev.azure.com/dnceng/internal/_build?definitionId=1675&_a=summary was failing because the SDL checks take over 60 minutes to run so I had to increase the timeout. I cannot try to validate this completely on my own branch due to branch protections but I did confirm it passed checks with this change, shown by the most recent run.

@nagilson
nagilson requested a review from MiYanni as a code owner September 4, 2026 20:17
Copilot AI lite review requested due to automatic review settings September 4, 2026 20:17
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped to pipeline configuration and correctly wires an existing timeout mechanism through the job-matrix template without altering build/test logic.

Pull request overview

This PR updates the AzDO SDL checks pipeline to avoid job timeouts by allowing the shared SDK job-matrix template to accept a configurable job timeoutInMinutes, and setting it to 90 minutes for the SDL pipeline legs.

Changes:

  • Add a timeoutInMinutes parameter to eng/pipelines/templates/jobs/sdk-job-matrix.yml so callers can pass a job timeout through to sdk-build.yml.
  • Set timeoutInMinutes: 90 for the Windows/Linux/macOS job-matrix invocations in .vsts-sdl.yml to accommodate SDL checks that exceed 60 minutes.
  • Replace the header comment in .vsts-sdl.yml with a link to the corresponding AzDO pipeline definition.
File summaries
File Description
eng/pipelines/templates/jobs/sdk-job-matrix.yml Adds a pass-through parameter enabling callers to override job timeouts.
.vsts-sdl.yml Applies a 90-minute timeout override to the SDL pipeline job-matrix invocations.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

@nagilson
nagilson requested a review from a team September 4, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants