Increase SDL pipeline job timeout - #56140
Open
nagilson wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
nagilson
enabled auto-merge
September 4, 2026 20:18
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to pipeline configuration and correctly wires an existing timeout mechanism through the job-matrix template without altering build/test logic.
Pull request overview
This PR updates the AzDO SDL checks pipeline to avoid job timeouts by allowing the shared SDK job-matrix template to accept a configurable job timeoutInMinutes, and setting it to 90 minutes for the SDL pipeline legs.
Changes:
- Add a
timeoutInMinutesparameter toeng/pipelines/templates/jobs/sdk-job-matrix.ymlso callers can pass a job timeout through tosdk-build.yml. - Set
timeoutInMinutes: 90for the Windows/Linux/macOS job-matrix invocations in.vsts-sdl.ymlto accommodate SDL checks that exceed 60 minutes. - Replace the header comment in
.vsts-sdl.ymlwith a link to the corresponding AzDO pipeline definition.
File summaries
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/sdk-job-matrix.yml | Adds a pass-through parameter enabling callers to override job timeouts. |
| .vsts-sdl.yml | Applies a 90-minute timeout override to the SDL pipeline job-matrix invocations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the pipeline in AzDo.
But, https://dev.azure.com/dnceng/internal/_build?definitionId=1675&_a=summary was failing because the SDL checks take over 60 minutes to run so I had to increase the timeout. I cannot try to validate this completely on my own branch due to branch protections but I did confirm it passed checks with this change, shown by the most recent run.