Skip to content

Added snippet for the await operator article - #1366

Merged
BillWagner merged 7 commits into
dotnet:masterfrom
pkulikov:await-operator-snippet
Aug 29, 2019
Merged

BillWagner merged 7 commits into
dotnet:masterfrom
pkulikov:await-operator-snippet

Conversation

@pkulikov

@pkulikov pkulikov commented Aug 29, 2019 •

Copy link
Copy Markdown
Contributor

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for completing this and the associated docs PR. This is an important milestone! 🎆 🍾

I had one small nit here, and then this is ready to :shipit:

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkulikov The last update missed a few instances of the old name.

I think I updated them all on this review.

pkulikov and others added 5 commits August 29, 2019 16:37
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
@pkulikov

Copy link
Copy Markdown
Contributor Author

Thank you @BillWagner. I remember to update the article text, but the rename refactoring has slipped my mind.

@BillWagner

Copy link
Copy Markdown
Member

Thanks @pkulikov I'm glad we caught everything before shipping it.

It's ready now.

@BillWagner
BillWagner merged commit 405e01c into dotnet:master Aug 29, 2019
@pkulikov
pkulikov deleted the await-operator-snippet branch August 29, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants