[release/8.0] Only initialize listeners once - #90932
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #90902 to release/8.0 /cc @Tratcher Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
ViktorHofer
added
area-System.Diagnostics.Metric
and removed
area-Infrastructure-libraries
labels
|
@Tratcher could you please add a test for the issue fixed here? I mean a test calling AddMetrics multiple times. |
|
@jeffhandley this issue needs your blessing to merge and track. Thanks! |
|
@Tratcher thanks for adding the test. When we get a green CI here, it will be good if you can backport this test to the main too. |
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
I approve of this fix for RC2. @Tratcher Did these tests get merged into main as well?
|
The fix is in main. I'll merge the additional test into main after this. |
carlossanlop
added
Servicing-approved
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/5956831413 |
ghost
locked as resolved and limited conversation to collaborators
6 participants
Backport of #90902 to release/8.0 for RC2.
AddMetrics uses an options validation workaround to initialize the MetricsSubscriptionManager and IMetricsListeners. However, if AddMetrics is called multiple times, it will do the initialization multiple times. IMetricsListener implementations may not be expecting that.
Customer Impact
IMetricsListener implementations may not expect/handle Initialize being called multiple times.
Testing
Manual
Risk
Low, this was a new component in RC1.