Skip to content

Support DllImportSearchPath.AssemblyDirectory for NativeAOT applications - #90120

Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime89874
Aug 8, 2023
Merged

Support DllImportSearchPath.AssemblyDirectory for NativeAOT applications#90120
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
AaronRobinsonMSFT:runtime89874

Conversation

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

Fixes #89874

on Windows.

Reenable the NativeLibrary tests
directory when DllImportSearchPath.AssemblyDirectory
is defined.
@ghost

ghost commented Aug 7, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #89874

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: 8.0.0

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member Author

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.csproj Outdated
Comment thread src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.csproj Outdated
Comment thread src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.cs
Comment thread src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.cs Outdated
@AaronRobinsonMSFT

Copy link
Copy Markdown
Member Author

Failures appear to be known.

@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 33400d8 into dotnet:main Aug 8, 2023
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the runtime89874 branch August 8, 2023 14:39
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NativeAOT fails to resolve PInvoke in System.Data.SqlClient

3 participants