Skip to content

[wasm] Move code around in WBT in preparation for fixes, and cleanups - #88980

Merged
radical merged 15 commits into
dotnet:mainfrom
radical:wbt-follow-pr-first
Jul 17, 2023
Merged

[wasm] Move code around in WBT in preparation for fixes, and cleanups#88980
radical merged 15 commits into
dotnet:mainfrom
radical:wbt-follow-pr-first

Conversation

@radical

@radical radical commented Jul 17, 2023

Copy link
Copy Markdown
Member
  • WBT: Move some common methods to TestUtils.cs
  • WBT: Add new project type specific base classes for the tests
  • WBT: Move blazor specific code from BuildTestBase into
  • WBT: Move more code from BuildTestBase to the respective provider, and test classes

This PR is mainly moving code around, and not fixing, cleaning, or rationalizing code.

A follow up PR will start merging common code, fixing testing bundles, icu etc.

radical added 3 commits July 17, 2023 00:47
.. BlazorWasmProjectProvider, and BlazorWasmTestBase. This commit avoids
doing any cleanup, and just moves code around.
@radical radical added the arch-wasm WebAssembly architecture label Jul 17, 2023
@ghost ghost added the area-Build-mono label Jul 17, 2023
@ghost ghost assigned radical Jul 17, 2023
@ghost

ghost commented Jul 17, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • WBT: Move some common methods to TestUtils.cs
  • WBT: Add new project type specific base classes for the tests
  • WBT: Move blazor specific code from BuildTestBase into
  • WBT: Move more code from BuildTestBase to the respective provider, and test classes
Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@radical
radical force-pushed the wbt-follow-pr-first branch from bd9e372 to a6fb183 Compare July 17, 2023 05:30
@radical
radical requested review from maraf and pavelsavara July 17, 2023 05:31
@radical
radical requested a review from lewing July 17, 2023 06:50
@radical

radical commented Jul 17, 2023

Copy link
Copy Markdown
Member Author

I would suggest reviewing this commit-wise.

@radical radical changed the title [wasm] Move code around in WBT in preparation for fixes, and cleanups" [wasm] Move code around in WBT in preparation for fixes, and cleanups Jul 17, 2023
@radical
radical marked this pull request as ready for review July 17, 2023 08:49
@radical

radical commented Jul 17, 2023

Copy link
Copy Markdown
Member Author

Missed updating the list of tests. I'll open a separate PR after these refactoring ones to generate the list at build time.

@maraf maraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@radical
radical merged commit 6e65f51 into dotnet:main Jul 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants