Move ASG rationalization to just after global morph - #85494
Merged
BruceForstall merged 28 commits intoMay 6, 2023
Conversation
ghost
added
community-contribution
SingleAccretion
marked this pull request as draft
April 27, 2023 23:03
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCI/diffs check.
|
SingleAccretion
force-pushed
the
Op-Req-Asg-Before-Global-Morph
branch
from
April 27, 2023 23:05
a6d0c3b to
cf5d92f
Compare
SingleAccretion
force-pushed
the
Op-Req-Asg-Before-Global-Morph
branch
from
April 28, 2023 17:40
cf5d92f to
4fd88a7
Compare
Contributor
Author
|
Overall TP diff:
(Only MinOpts regression is in a CG collection, which is not representative) |
SingleAccretion
force-pushed
the
Op-Req-Asg-Before-Global-Morph
branch
from
May 1, 2023 18:54
4fd88a7 to
114df04
Compare
SingleAccretion
force-pushed
the
Op-Req-Asg-Before-Global-Morph
branch
from
May 2, 2023 20:49
114df04 to
2c022d5
Compare
SingleAccretion
force-pushed
the
Op-Req-Asg-Before-Global-Morph
branch
from
May 2, 2023 20:56
2c022d5 to
1aa7ffd
Compare
This was referenced May 3, 2023
SingleAccretion
marked this pull request as ready for review
May 3, 2023 16:13
Contributor
Author
|
There are a few code diffs. They come from two sources:
@dotnet/jit-contrib |
…Asg-Before-Global-Morph
Contributor
|
This looks great, and the throughput improvement is amazing. Let's run some stress... |
Contributor
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
The only test failure is #85663 |
BruceForstall
approved these changes
May 6, 2023
BruceForstall
approved these changes
May 6, 2023
BruceForstall
left a comment
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
Thanks again for your substantial contributions to RyuJIT!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the rationalization further up the phase list, placing it just before global morph.