Remove some Windows specific formatters - #78434
Merged
AaronRobinsonMSFT merged 9 commits intoNov 17, 2022
Merged
Conversation
AaronRobinsonMSFT
requested review from
lambdageek and
lateralusX
as code owners
November 16, 2022 00:49
ghost
assigned
jkotas
approved these changes
Nov 16, 2022
Member
Author
|
Unsure why this built on macOS... |
janvorli
reviewed
Nov 16, 2022
janvorli
left a comment
janvorli
left a comment
Member
There was a problem hiding this comment.
I just gave it a quick look, I'll take another one tomorrow.
am11
reviewed
Nov 16, 2022
janvorli
reviewed
Nov 16, 2022
Member
Author
|
@janvorli I think I've addressed your feedback. Any other concerns? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has two primary sets of changes, remove the
%I64/%Iand%Sfrom format strings that exist in unmanaged code. All of the%I*formats have been removed, but many%Sstill remain (approx 150). The latter must be fully removed before we can delete our private copy ofprintf./cc @janvorli @elinor-fung @am11 @jkotas