[release/6.0] Fix gcc warnings during mono linux-x64 build (backport of #60675) - #77505
Conversation
|
@am11 Is this something that looks good for you as far as a direct backport, or is there something missing on my implementation? |
|
Why do these warning fixes need to be backported ? |
|
Without this, build of |
|
The commit doesn't spell it out, but this also fixes build errors when building .NET with clang 15. We needed this to be able to build .NET 6 on Fedora 37. |
c22b0d0 to
6ad6fd0
Compare
|
This a partial backport of the linked PR. Looks good. Thanks!
Understandable; 577a70a is a one year old commit, while clang-15 was released two months ago. |
|
@vargaz @lambdageek @marek-safar this needs to go through Tactics. When/if this is ready, please add the |
|
Ping @lambdageek @marek-safar @vargaz. Also, the CI seems to be stuck, so it needs a restart. I'm closing and reopening. |
|
@vargaz @lambdageek @marek-safar this has not been approved by Tactics yet. Can you please send the approval email? The deadline is the 14th. |
|
@vargaz @marek-safar @carlossanlop I emailed tactics |
|
Approved by tactics. |
|
Signed off by area owner. |
Backport of #60675 to
release/6.0Per @am11
Customer impact
Mono flavored-runtime will be less prone to errors
Testing
Risk
Low, as it is already in
main, and only activates when cmake for linux test passes.