Skip to content

[release/6.0] Source-Build: Remove ILStrip dependency from mono - #77503

Closed
ayakael wants to merge 1 commit into
dotnet:release/6.0from
ayakael:remove-ilstrip-mono-sourcebuild
Closed

[release/6.0] Source-Build: Remove ILStrip dependency from mono#77503
ayakael wants to merge 1 commit into
dotnet:release/6.0from
ayakael:remove-ilstrip-mono-sourcebuild

Conversation

@ayakael

@ayakael ayakael commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Per @omajid: "Mono still has a dependency on (now unbuildable) ILStrip which was removed from CoreCLR"

This was in Fedora's patch list and is now used for building dotnet6 on Alpine Linux.

@ayakael
ayakael requested a review from marek-safar as a code owner October 26, 2022 19:18
@ghost ghost added area-Build-mono community-contribution Indicates that the PR has been added by a community member labels Oct 26, 2022
@ayakael ayakael changed the title [release/6.0] Source-Build: Remove ILStrip depedency from mono [release/6.0] Source-Build: Remove ILStrip dependency from mono Oct 26, 2022
@teo-tsirpanis teo-tsirpanis added this to the 6.0.x milestone Oct 26, 2022
@akoeplinger

Copy link
Copy Markdown
Member

So #61607 wasn't enough?

@omajid

omajid commented Oct 27, 2022

Copy link
Copy Markdown
Member

@ayakael IIRC, @uweigand and I came up with slightly different fixes for the same issue and they both did effectively the same thing. Uli's PR #61607 was merged into main and then backported to 6.0 as #63701. Maybe this PR isn't needed? Did you try building without it?

@ayakael

ayakael commented Oct 27, 2022

Copy link
Copy Markdown
Contributor Author

@ayakael IIRC, @uweigand and I came up with slightly different fixes for the same issue and they both did effectively the same thing. Uli's PR #61607 was merged into main and then backported to 6.0 as #63701. Maybe this PR isn't needed? Did you try building without it?

I'll try without.

@ayakael

ayakael commented Oct 29, 2022

Copy link
Copy Markdown
Contributor Author

Yup, building without this patch works. Sorry for the noise, closing.

@ayakael ayakael closed this Oct 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Build-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants