Skip to content

[wasm] fix NodeJS build - #75187

Merged
pavelsavara merged 2 commits into
dotnet:mainfrom
pavelsavara:wasm_fix_nodejs
Sep 8, 2022
Merged

[wasm] fix NodeJS build#75187
pavelsavara merged 2 commits into
dotnet:mainfrom
pavelsavara:wasm_fix_nodejs

Conversation

@pavelsavara

@pavelsavara pavelsavara commented Sep 7, 2022

Copy link
Copy Markdown
Member

unix batch files have case sensitive equals

Fixes #75098

@pavelsavara pavelsavara added this to the 8.0.0 milestone Sep 7, 2022
@pavelsavara
pavelsavara requested a review from maraf September 7, 2022 09:45
@pavelsavara
pavelsavara requested a review from radical as a code owner September 7, 2022 09:45
@pavelsavara pavelsavara self-assigned this Sep 7, 2022
@ghost

ghost commented Sep 7, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 8.0.0

@pavelsavara

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara merged commit e0835c9 into dotnet:main Sep 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
@pavelsavara
pavelsavara deleted the wasm_fix_nodejs branch October 13, 2022 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] Test failure when AOT'ed with SIMD support - JSException : TypeError: globalThis.WebSocket is not a constructor

3 participants