Skip to content

Disable the GetTotalPauseDuration test - #75141

Merged
cshung merged 2 commits into
dotnet:mainfrom
cshung:public/disable-pause-duration-test
Sep 7, 2022
Merged

Disable the GetTotalPauseDuration test#75141
cshung merged 2 commits into
dotnet:mainfrom
cshung:public/disable-pause-duration-test

Conversation

@cshung

@cshung cshung commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Temporarily disabling the test for #74631

@cshung cshung self-assigned this Sep 6, 2022
@ghost

ghost commented Sep 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

@mangod9

mangod9 commented Sep 6, 2022

Copy link
Copy Markdown
Member

technically its only failing on arm64? This disables it for all platforms correct?

@cshung

cshung commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

technically its only failing on arm64? This disables it for all platforms correct?

Yes, this will disables it for all platforms. Is it possible to disable it for arm64 windows only? How?

@mangod9

mangod9 commented Sep 6, 2022

Copy link
Copy Markdown
Member

you could do it in issues.targets:

<!-- Arm64 All OS -->

@mangod9

mangod9 commented Sep 6, 2022

Copy link
Copy Markdown
Member

you could do it in issues.targets:

<!-- Arm64 All OS -->

And if win-arm64 only:

<!-- Windows arm64 specific excludes -->

@cshung

cshung commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

you could do it in issues.targets:

<!-- Arm64 All OS -->

And if win-arm64 only:

<!-- Windows arm64 specific excludes -->

Thanks, once the test is disabled using issues.target, will it be run at all?
Since the test don't fail locally, I'd love to see what happened when it fail with this PR.

@cshung
cshung merged commit b7dadfd into dotnet:main Sep 7, 2022
@cshung
cshung deleted the public/disable-pause-duration-test branch September 7, 2022 18:11
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants