Skip to content

[wasm] InterpToNativeGenerator: use invariant culture when generating C - #71460

Merged
radical merged 2 commits into
dotnet:mainfrom
radical:fix-pinvoke-turk
Jun 30, 2022
Merged

[wasm] InterpToNativeGenerator: use invariant culture when generating C#71460
radical merged 2 commits into
dotnet:mainfrom
radical:fix-pinvoke-turk

Conversation

@radical

@radical radical commented Jun 29, 2022

Copy link
Copy Markdown
Member

.. functions.

Wasm native build in Turkish culture would fail with:

In file included from C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.browser-wasm\7.0.0-preview.6.22312.1\runtimes\browser-wasm\native\src\driver.c:37: (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:13:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0)); (TaskId:242)
                        ^ (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:23:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0), mono_wasm_interp_method_args_get_─▒arg (margs, 1), mono_wasm_interp_method_args_get_─▒arg (margs, 2)); (TaskId:242)
                        ^ (TaskId:242)

This is odd character in the function name is 'I' converted (in Turkish) to lower case, which is not 'i'.

Fixes #71149

@radical
radical requested review from lewing, maraf and radekdoulik June 29, 2022 20:38
@ghost ghost added the area-Build-mono label Jun 29, 2022
@radical radical added the arch-wasm WebAssembly architecture label Jun 29, 2022
@ghost ghost assigned radical Jun 29, 2022
@ghost

ghost commented Jun 29, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. functions.

Wasm native build in Turkish culture would fail with:

In file included from C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.browser-wasm\7.0.0-preview.6.22312.1\runtimes\browser-wasm\native\src\driver.c:37: (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:13:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0)); (TaskId:242)
                        ^ (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:23:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0), mono_wasm_interp_method_args_get_─▒arg (margs, 1), mono_wasm_interp_method_args_get_─▒arg (margs, 2)); (TaskId:242)
                        ^ (TaskId:242)

This is odd character in the function name is 'I' converted (in Turkish) to lower case, which is not 'i'.

Fixes #71149

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical

radical commented Jun 29, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Jun 29, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Jun 30, 2022

Copy link
Copy Markdown
Member Author

Coreclr failure is #71475 .
WBT failure is #70675, unrelated to this PR.

@radical
radical merged commit 14dac22 into dotnet:main Jun 30, 2022
@radical
radical deleted the fix-pinvoke-turk branch June 30, 2022 06:15
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With .NET7 preview 6 SDK installed on Turkish OS, error happen when dotnet publish with AOT enable.

2 participants