Fix documentation issues in recent DateTime API additions - #68019
Merged
Conversation
The microseconds parameter accepts 0-999, not 0-900.
ghost
assigned
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsThe microseconds parameter accepts 0-999, not 0-900. This was likely a copy/paste mistake from nanoseconds in #67666 /cc @tarekgh @deeprobin
|
Contributor
|
I thought it accepts 0-999 but is has only a precision of 100ns. Is using 901 throwing an exception, if yes this PR lgtm. |
Contributor
Right, but if you supply 999us the math will round it. |
deeprobin
approved these changes
Apr 14, 2022
deeprobin
left a comment
deeprobin
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this fix 👍🏼.
This LGTM.
tarekgh
approved these changes
Apr 14, 2022
stephentoub
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The microseconds parameter accepts 0-999, not 0-900. This was likely a copy/paste mistake from nanoseconds in #67666
/cc @tarekgh @deeprobin