[wasm] Rename $(EmccInitialMemory) to $(EmccInitialHeapSize) - #66233
Merged
Conversation
.. to better represent what it is.
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details.. to better represent what it is.
|
ghost
assigned
kg
reviewed
Mar 5, 2022
| <EmccInitialMemory Condition="'$(EmccInitialMemory)' == ''">$(EmccTotalMemory)</EmccInitialMemory> | ||
| <EmccInitialMemory Condition="'$(EmccInitialMemory)' == ''">536870912</EmccInitialMemory> | ||
| <EmccInitialHeapSize Condition="'$(EmccInitialHeapSize)' == ''">$(EmccTotalMemory)</EmccInitialHeapSize> | ||
| <EmccInitialHeapSize Condition="'$(EmccInitialHeapSize)' == ''">536870912</EmccInitialHeapSize> |
Contributor
There was a problem hiding this comment.
We should evaluate whether ~536mb is actually a reasonable initial heap size. It may be too big and causing OOM for applications that won't ever use that much
kg
approved these changes
Mar 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. to better represent what it is.