Take SuppressGCTransition into account in IL stub caching - #47320
Merged
elinor-fung merged 6 commits intoJan 27, 2021
Conversation
jkotas
reviewed
Jan 22, 2021
jkotas
reviewed
Jan 22, 2021
jkotas
reviewed
Jan 22, 2021
AaronRobinsonMSFT
approved these changes
Jan 26, 2021
Member
Author
|
@AaronRobinsonMSFT @jkoritzinsky thoughts on if we should try to take (a version of) this for 5? |
Member
|
I think we should. If we don't, users can end up with random GC pauses where one of their IL stubs hit a cache entry that was marked SuppressGCTransition. |
Member
|
@elinor-fung It's not a bad idea given it isn't easy to diagnose. I would like to see as much of the testing as was added here brought down to .NET 5 though. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the updated stub flags that have
SuppressGCTransitiontaken into account when creating the hash blob used for caching IL stubs.Fix #46184
cc @AaronRobinsonMSFT @jkoritzinsky