Initial addition of tvOS Mono - #34475
Merged
Merged
Conversation
akoeplinger
reviewed
Apr 2, 2020
This reverts commit b2917e9.
akoeplinger
reviewed
Apr 3, 2020
akoeplinger
reviewed
Apr 3, 2020
akoeplinger
reviewed
Apr 3, 2020
akoeplinger
reviewed
Apr 3, 2020
directhex
marked this pull request as ready for review
April 6, 2020 20:10
directhex
requested review from
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
April 6, 2020 20:10
steveisok
reviewed
Apr 6, 2020
akoeplinger
requested changes
Apr 7, 2020
akoeplinger
left a comment
akoeplinger
left a comment
Member
There was a problem hiding this comment.
Looks very good, only a few changes to address :)
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
This reverts commit 570884e.
akoeplinger
approved these changes
Apr 7, 2020
akoeplinger
left a comment
akoeplinger
left a comment
Member
There was a problem hiding this comment.
One nit, looks good otherwise!
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this works