JIT/EE interface cleanup

[jkotas]

Delete methods on JIT/EE interface that are no longer used in CoreCLR

[jkotas]

cc @dotnet/jit-contrib

[AndyAyersMS]

Would be good to verify this is zero-diff.

Seems like we could get rid of GTF_INX_REFARR_LAYOUT entirely.

[AndyAyersMS]

Superpmi not happy.

[BruceForstall]

The SuperPMI unit test finally found what it was designed to find. Nice.

[AndyAyersMS]

Thanks, Jan.

[AndyAyersMS]

Yeah, I think we should do this, but it doesn't have to be done now.

[jkotas]

I have reverted the GTF_INX_REFARR_LAYOUT layout removal. It was causing asm diffs. I have added TODO comment for it instead so that it can be dealt with separately - will open an issue.

Example of asm diff:

Baseline:

mov rcx, qword ptr [0x1ce08]  // object (TYPE_HANDLE)
call qword ptr [0x10c8]       // GET_RUNTIME_TYPE_HANDLE (HELPER)
cmp qword ptr [rbp + 160], rax

With GTF_INX_REFARR_LAYOUT removed:

mov rbp, qword ptr [rcx + 160]
mov rcx, qword ptr [0x1ce08]  // object (TYPE_HANDLE)
call qword ptr [0x10c8]       // GET_RUNTIME_TYPE_HANDLE (HELPER)
cmp rbp, rax

My guess is that that there is a place in register allocator (have not traced down where exactly) that compares all flags without interpreting them.

[jkotas]

src/installer/pkg/projects/Directory.Build.props(4,3): error : System.AggregateException: One or more errors occurred. (Could not find a part of the path '/tmp/NuGetScratch/eeea79e456214a75b7f5887557384111/136e41645a9a49b0860273810a1411c4.proj.nuget.dgspec.json'.)
 ---> System.IO.DirectoryNotFoundException: Could not find a part of the path '/tmp/NuGetScratch/eeea79e456214a75b7f5887557384111/136e41645a9a49b0860273810a1411c4.proj.nuget.dgspec.json'.
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at System.IO.FileStream..ctor(String path, FileMode mode)
   at NuGet.ProjectModel.DependencyGraphSpec.Save(String path)
   at NuGet.Commands.NoOpRestoreUtilities.PersistDGSpecFile(DependencyGraphSpec spec, String dgPath, ILogger log)
   at NuGet.Commands.RestoreCommand.EvaluateCacheFile()
   at NuGet.Commands.RestoreCommand.ExecuteAsync(CancellationToken token)
   at NuGet.Commands.RestoreRunner.ExecuteAsync(RestoreSummaryRequest summaryRequest, CancellationToken token)
   at NuGet.Commands.RestoreRunner.CompleteTaskAsync(List`1 restoreTasks)
   at NuGet.Commands.RestoreRunner.RunWithoutCommit(IEnumerable`1 restoreRequests, RestoreArgs restoreContext)
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at Microsoft.Build.NuGetSdkResolver.NuGetSdkResolver.NuGetAbstraction.GetSdkResult(SdkReference sdk, Object nuGetVersion, SdkResolverContext context, SdkResultFactory factory)

[jkotas]

Known issue: #32638