Skip to content

Add websocket scheme support to HttpEnvironmentProxy.cs - #32302

Merged
davidsh merged 1 commit into
dotnet:masterfrom
daddyman:issue_32230_websocketproxy
Feb 24, 2020
Merged

davidsh merged 1 commit into
dotnet:masterfrom
daddyman:issue_32230_websocketproxy

Conversation

@daddyman

Copy link
Copy Markdown
Contributor

Fixes #32230

Use insecure proxy (http_proxy) for schemes http and ws.
Use secure proxy (https_proxy) to schemes https and wss.

Use insecure proxy (http_proxy) for schemes http and ws
Use secure proxy (https_proxy) to schemes https and wss
@dnfclas

dnfclas commented Feb 14, 2020 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidsh davidsh added this to the 5.0 milestone Feb 14, 2020

@davidsh davidsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@davidsh

davidsh commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

/azp list

@davidsh davidsh closed this Feb 20, 2020
@davidsh davidsh reopened this Feb 20, 2020
@davidsh

davidsh commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

CI failures unrelated to PR.

@davidsh
davidsh merged commit 67e9a10 into dotnet:master Feb 24, 2020
@daddyman
daddyman deleted the issue_32230_websocketproxy branch February 25, 2020 02:32
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientWebSocket on Linux uses wrong proxy if http and https proxies are different

7 participants