Skip to content

Fix CG2 framework compilation on Linux / OSX - #32265

Merged
trylek merged 1 commit into
dotnet:masterfrom
trylek:LinuxCG2Framework
Feb 14, 2020
Merged

trylek merged 1 commit into
dotnet:masterfrom
trylek:LinuxCG2Framework

Conversation

@trylek

@trylek trylek commented Feb 13, 2020 •

Copy link
Copy Markdown
Member

Crossgen2 framework compilation was failing due to incorrect quoting in the command line. I have also improved diagnosability of similar issues in the future by adding support for printing the command line when a compilation fails.

Thanks

Tomas

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Feb 13, 2020
@trylek
trylek force-pushed the LinuxCG2Framework branch 5 times, most recently from 35a9893 to cdec9f6 Compare February 14, 2020 09:44
@trylek trylek changed the title WIP: fix CG2 framework compilation on Linux / OSX Fix CG2 framework compilation on Linux / OSX Feb 14, 2020
@trylek
trylek requested a review from janvorli February 14, 2020 16:19

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@trylek
trylek merged commit 77d88f0 into dotnet:master Feb 14, 2020
@trylek
trylek deleted the LinuxCG2Framework branch February 14, 2020 18:45
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants