Repository navigation
fix infinite recursion in crossgen2 on ARM - #32227
Conversation
|
cc @dotnet/crossgen-contrib |
|
I would prefer we do what @jkotas originally suggested in the issue: "Keep track of maximum alignment in I would also change the Computing the |
be338b1 to
bd7c509
Compare
|
@MichalStrehovsky |
bd7c509 to
bdcc1ee
Compare
There was a problem hiding this comment.
Could you please do this in the // Iterate over all fields and do the following foreach loop?
That loop already calls ComputeFieldSizeAndAlignment in one of the branches and we can save us a call.
There was a problem hiding this comment.
oh, I didn't notice that the comment addresses specific place in code and picked the first loop over fields in the body
There was a problem hiding this comment.
This check is not necessary. Calling AsInt is going to throw if the value is indeterminate. This might actually be reachable at some point. Once it is we will deal with it.
bdcc1ee to
79e2e2d
Compare
There was a problem hiding this comment.
This needs to go above the cascading if block, together with the line above it.
79e2e2d to
b7348ec
Compare
|
Thank you for your help! |
This PR fixes #32120.
Despite it is not used in
ReadyToRunMetadataFieldLayoutAlgorithm::AlignBaseOffsetIfNecessaryI think we should pass proper default alignment, but I don't sure it is4: now field's alignment requirements are tracking byMetadataFieldLayoutAlgorithm::ComputeAutoFieldLayout.Also if we try to call
TypeExtensions::RequiredAlign8(this TypeDesc)just fromMetadataFieldLayoutAlgorithm's method we face missing dependency, so I decided to havevirtualmethod tooverrideinReadyToRunMetadataFieldLayoutAlgorithm.