Repository navigation
JIT: Size the global assertion table by the actual number of assertions - #136421
Merged
Merged
Conversation
Instead of sizing the global assertion table (and the bit vectors) upfront via a heuristic, grow the table on demand during assertion gen (up to 512) and size the bit vectors by the actual number of assertions afterwards. This avoids dropping assertions in methods the heuristic underpredicted, and avoids larger than needed bit vectors in methods it overpredicted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6dfca0e-42e2-45de-99de-222d54fe6937
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Assertions against integer constants can only constrain their left-hand VN. Reject unrelated ones before evaluating the remaining range-analysis cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e6dfca0e-42e2-45de-99de-222d54fe6937
EgorBo
marked this pull request as ready for review
October 26, 2026 10:42
EgorBo
commented
Oct 26, 2026
Member
Author
|
PTAL @dotnet/jit-contrib size/TP improvement. It is needed for extra assertions I wanted to fit there. |
tannergooding
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of sizing the global assertion table upfront via the
max(64, min(256, (lvaTrackedCount + 3*fgBBcount + 48) >> 2))heuristic, the table now starts at 64 entries and grows on demand during assertion generation (up to 512). Once generation is done, the bit vector traits are sized by the actual number of assertions.Some nice diffs and TP improvement