Repository navigation
Reduce universal DBI source closure - #136374
Merged
max-charlamb merged 5 commits intoOct 26, 2026
Merged
max-charlamb merged 5 commits into
max-charlamb merged 5 commits into
Conversation
No-host utilcode disables its ETW call sites through SELF_NO_HOST, so avoid including generated eventing headers and remove the corresponding CMake dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25eb53f8-927f-498d-94f9-0c2da243e293
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
added 3 commits
October 23, 2026 14:39
Move the MSLAYOUT definition to a small shared header so debugger common structures do not include dacprivate.h solely for that macro. This removes dacprivate.h, xclrdata.h, sospriv.h, msodw.h, and livedatatarget.h from the universal DBI source closure, reducing it by roughly 14,000 physical lines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25eb53f8-927f-498d-94f9-0c2da243e293
Keep the CLRDATA_ADDRESS dependency explicit after removing dacprivate.h from the shared debugger header. This preserves the universal DBI build on Unix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25eb53f8-927f-498d-94f9-0c2da243e293
The runtime data descriptor exports sizeof(GenericModeBlock) on Windows. Include msodw.h directly instead of relying on debugger common.h to pull it through dacprivate.h. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25eb53f8-927f-498d-94f9-0c2da243e293
max-charlamb
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25eb53f8-927f-498d-94f9-0c2da243e293
max-charlamb
marked this pull request as ready for review
October 26, 2026 15:03
AaronRobinsonMSFT
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce the source closure required to build the
mscordbi_universalby:SELF_NO_HOSTutilcode, where the eventing call sites are disabledeventing_headersdependencies from the DBI implementation libraries and keep that dependency only on hostedutilcodeMSLAYOUTinto a small standalone header so debugger common structures no longer pull indacprivate.hand its DAC-only transitive dependencies (xclrdata.h,sospriv.h,msodw.h, andlivedatatarget.h)