Skip to content

[cDAC] Fix incorrect filtering of stack-interior references - #136089

Merged
max-charlamb merged 1 commit into
dotnet:mainfrom
SwapnilGaikwad:github-fix-x86-cdac-stress-test
Oct 20, 2026
Merged

max-charlamb merged 1 commit into
dotnet:mainfrom
SwapnilGaikwad:github-fix-x86-cdac-stress-test

Conversation

@SwapnilGaikwad

Copy link
Copy Markdown
Contributor

Some runtime paths report stack-interior references without using PromoteCarefully. Filter these references from both cDAC and runtime results before comparison so asymmetric filtering does not produce false stress-test failures.

NOTE: This PR is created with the help of codex to address failing CI pipeline for #135959

cc: @dotnet/arm64-contrib @dhartglassMSFT @max-charlamb

Some runtime paths report stack-interior references without using PromoteCarefully.
Filter these references from both cDAC and runtime results before comparison
so asymmetric filtering does not produce false stress-test failures.
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Oct 19, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

@SwapnilGaikwad SwapnilGaikwad changed the title Try fixing cdac stress tests on windows x86 [cDAC] Fix incorrect filtering of stack-interior references Oct 19, 2026

@max-charlamb max-charlamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@max-charlamb

Copy link
Copy Markdown
Member

/ba-g all test runs passed

@max-charlamb
max-charlamb merged commit 7f139f6 into dotnet:main Oct 20, 2026
148 of 150 checks passed
@SwapnilGaikwad
SwapnilGaikwad deleted the github-fix-x86-cdac-stress-test branch October 20, 2026 15:02
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants