Repository navigation
[release/11.0] Give the nested process chain in ProcessWaitingTests depth-proportional wait budgets - #135643
Merged
Conversation
…al wait budgets (#135608) Fixes #118977 ## Problem `ProcessWaitingTests.WaitChain` and `WaitAsyncChain` start a four-deep chain of `RemoteExecutor` processes, and every level waits with the same `WaitInMS`. The root's wait has to cover the start-up, work and exit of all four processes while the leaf's covers one, so the root has the leaf's budget while covering four lifetimes. ## Change Give each waiter `WaitInMS` per process beneath it: leaf 1×, then 2×, 3× and 4× at the root. > [!NOTE] > This PR was prepared with AI assistance (Anthropic Claude, checked by OpenAI Codex) at my request. I reviewed the change and the measurements before opening it.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
This was referenced Oct 13, 2026
adamsitnik
approved these changes
Oct 13, 2026
adamsitnik
left a comment
adamsitnik
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you for backporting it @ViveliDuCh !
Member
|
/ba-g Only known failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #135608 to release/11.0
/cc @ViveliDuCh @pcshrosbree
The same
WaitChain/WaitAsyncChaintimeout failure seen in main also occurred inrelease/11.0. Scale each wait budget by the number of nested processes it covers.Customer Impact
Intermittent CI test failures; no product behavior change.
Regression
Existing test timeout issue; no known product regression.
Testing
#135608 reports both chain tests passing on Windows x86, Linux x64, and macOS arm64. No additional local tests run for this backport; CI is still in progress and currently has failures.
Risk
Low: test-only timeout adjustment. Assertions and product code are unchanged.