Repository navigation
Conversation
…ishing IL With the base SDK ReadyToRun tasks, a non-composite CoreCLR browser-wasm publish runs crossgen2 in composite mode per assembly and names the output <name>.dll. That image is a composite owner whose metadata MVID is empty, so ConvertDllsToWebcil's MVID guard rejected it and silently converted IL instead: the publish succeeded with no ReadyToRun code. Treat an empty prebuilt MVID as an error pointing at the Crossgen2SdkOverride properties (dotnet/sdk#55785), and return !Log.HasLoggedErrors from Execute. Genuine non-empty MVID mismatches still fall back to IL. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6eba4d35-1574-4503-8c7f-7ee485aafa4e
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CoreCLR browser-wasm R2R publish using the base SDK ReadyToRun tasks (without
Crossgen2SdkOverride*) succeeds but ships IL only. Those tasks run crossgen2 with--compositeper assembly and name the output<name>.dll(dotnet/sdk#55785), producing a composite owner image whose MVID is empty. The MVID guard from #133378 correctly rejects it, but falls back to IL silently.An empty prebuilt MVID is now a build error that points at the override properties. A non-empty MVID mismatch (a stale image) still falls back to IL. All parseable R2R images in the runtime pack have non-empty MVIDs.
ConvertDllsToWebcil_Fails_WhenPrebuiltR2RIsCompositecovers the new error.Note
This PR description and change were generated with GitHub Copilot.