Repository navigation
Use MoveToImmutable in ILLink.RoslynAnalyzer - #135107
Merged
Merged
Conversation
Update ImmutableArray<T>.Builder usages in ILLink.RoslynAnalyzer to call MoveToImmutable instead of ToImmutable/ToImmutableArray. As a follow-up to PR dotnet#134426, this applies the changes made in ILLink and ILCompiler.Compiler to ILLink.RoslynAnalyzer as well.
github-actions
Bot
added
the
area-Tools-ILLink
dotnet-policy-service
Bot
added
linkable-framework
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The performance-only change lacks the repository-required before-and-after measurement evidence.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Replaces copying immutable-array conversions with zero-copy transfers where builder capacity exactly matches item count.
Changes:
- Uses
MoveToImmutable()across analyzer/shared trimming paths. - Preallocates argument builders with exact capacities.
- Aligns analyzer implementations with ILLink and ILCompiler counterparts.
| File | Description |
|---|---|
HandleCallAction.cs |
Transfers generic-parameter values without copying. |
TypeProxy.cs |
Transfers type generic parameters without copying. |
TrimAnalysisMethodCallPattern.cs |
Preallocates and transfers argument arrays. |
MethodProxy.cs |
Transfers method generic parameters without copying. |
sbomer
approved these changes
Oct 6, 2026
Contributor
Author
|
@sbomer Thanks for the approval. Is there anything else I should do? |
Member
|
Nope, thanks for the ping! I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
ImmutableArray<T>.Builderusages inILLink.RoslynAnalyzerandILLink.Sharedto callMoveToImmutableinstead ofToImmutableArray. As a follow-up to PR #134426, this applies the changes made inILLinkandILCompiler.CompilertoILLink.RoslynAnalyzerandILLink.Sharedas well.