[wasm][R2R] Fix closed static delegate struct returns by lewing · Pull Request #134108 · dotnet/runtime

lewing · 2026-09-16T22:06:17Z

Summary

Fix closed static delegates returning structs through a hidden return buffer on CoreCLR WebAssembly ReadyToRun.

A closed static delegate receives arguments using the instance Delegate.Invoke shape:

(sp, capturedTarget, retbuf, args..., delegatePEP)

The static target follows the Wasm aggregate-return ABI and expects:

(sp, retbuf, capturedTarget, args..., targetPEP)

Both pointer arguments lower to i32, so the previous direct dispatch passed Wasm type validation but silently exchanged the captured object and return-buffer address. Structs containing object references consequently returned null or invalid references.

Approach

Add a portable equivalent of ThisPtrRetBufPrecode, following the existing portable unboxing-stub design:

ClosedStaticRetBufPortableEntryPoint stores the target portable entrypoint immediately before its embedded PEP.
Crossgen2 emits a D-prefixed WasmClosedStaticRetBufThunkNode, shared by physical Wasm signature. It swaps the captured target and return-buffer parameters, then dispatches through the target PEP.
Both call-signature recording paths independently root the corresponding static-target R2R-to-interpreter thunk for each full interpreter-layout signature. Distinct aggregate sizes can share D code without losing their distinct I-thunk dependencies.
If either signature thunk is not loaded yet, the specialized PEP remains interpreter-preferred and is registered with the existing pending-thunk lifecycle. Later R2R module injection patches the same PEP in place.
Pending adapter registration is skipped when ReadyToRun is disabled because no later R2R string-thunk injection can resolve it; the interpreter fallback remains unchanged.
Pending adapter registration uses an O(1) flag on the portable entrypoint instead of scanning the loader allocator's list. The flag is published only after the fallible list appends complete, so cache-hit registration retries remain possible after an allocation failure.
The pending method and adapter lists share one SArray<void*> scan/compact helper driven by resolver function pointers. Resolution runs in two global passes—target method PEPs first, then closed-static adapters—so dependencies owned by separate loader allocators can complete during the same module injection.
Delegate construction prepares the target PEP before consulting the adapter cache, handling recycled LCG DynamicMethodDesc generations. Cached unresolved adapters also retry pending registration, including after a previous registration failure.
Shared generic targets arrive through instantiating wrappers, which carry their generic context without changing the delegate-compatible physical signature.
The runtime uses the same Wasm lowering classifier as GetSignatureKey to select only indirect aggregate returns, independently of whether ReadyToRun is enabled. Async targets are excluded because their hidden continuation parameter requires a different adapter shape.
Adapters are cached per target and delegate Invoke method, with collectible loader-allocator dependencies preserved.

This keeps the normal closed-delegate representation and preserves Target, Method, equality, and reverse MethodDesc mapping. Interpreted calls continue to use INTOP_CALLDELEGATE; compiled calls use the stable adapter PEP once its prerequisites are available. No generated IL adapter is needed.

Validation

After merging current main, including #133656, this PR removes the single temporary #133618 quarantine from System.Tests.DelegateTests.ClosedStaticDelegate. The test body and all assertions remain unchanged, so the trimmed browser CoreCLR ReadyToRun CI lane now exercises the original object-reference struct-return failure directly. Static verification confirmed that no other #133618 suppression exists in source. Live execution of the newly re-enabled library test is delegated to this PR's CI rather than repeated locally.

Latest stabilization pass:

CoreCLR tools/Crossgen2 Release, browser CoreCLR runtime Release and Checked, native CoreCLR Debug, and the focused test build succeeded with zero warnings/errors.
Browser-Wasm R2R WasmInterpreterTransitions: expected 100, actual 100. Coverage includes interpreted/R2R creation and targets, runtime-generated targets, generic wrappers, object-reference returns, direct-return controls, 32 LCG recycling generations with required collection, and colliding physical signatures with different aggregate argument layouts.
Signature-collision negative control: the new S8/S12 dynamic-target case traps with the previous compiler and passes with the fix. Emitted-image inspection confirms one shared D adapter and both layout-specific target I thunks. The shared adapter's generated instructions are unchanged.
Missing-thunk coverage: the emitted dynamic-only signature's D and I keys are absent from both the test and CoreLib images. Temporarily rejecting missing-thunk fallback fails specifically in VerifyDynamicClosedStaticDelegate; restoring fallback passes.
Registration-failure negative control: injecting a one-shot OOM immediately before the pending-list append leaves the old flag-first implementation with a cached but unregistered adapter and a later function signature mismatch. Publishing the flag after the append resolves the cached adapter on retry. Fault injection was removed before the final build.
Cross-loader ordering negative control: with the adapter allocator registered first, the old per-loader sweep resolved the target PEP (target-native=64190) but left the adapter unresolved (adapter-native=0). The two global passes resolved both (target-native=64190, adapter-native=64186) during the same module injection and the delegate invocation passed.
Local-only independent-assembly loading experiment: the same delegate invokes successfully before and after loading its separately compiled R2R caller on the final runtime.
With ReadyToRun disabled, basic closed-static invocation and the four affected dynamic/collision/recycling test helpers pass through a local driver.
A controlled no-PR comparison showed the earlier Checked startup assertions were caused by mixing a Checked runtime with a Release CoreLib/layout. Both the merge-base and PR runtimes pass with matching Checked artifacts; the PR transition fixture recompiled against that layout also passes.

Earlier revisions also passed desktop System.Runtime.Tests (79,400 total, zero failures, 89 skipped), an adapter-disabled negative control, and the LCG cache-order negative control. The full desktop suite was not rerun for this stabilization commit.

The separate loading, registration-failure, and cross-loader experiments remain local; this PR adds no new test harness or CI lane.

Resolves #133618

Note

This pull request was developed with GitHub Copilot assistance.

Add a portable-entrypoint adapter that reorders the captured target and hidden return buffer before dispatching to a closed static delegate target. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

azure-pipelines · 2026-09-16T22:07:02Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-09-16T22:07:31Z

Tagging subscribers to this area: @dotnet/crossgen-contrib
See info in area-owners.md if you want to be subscribed.

dotnet-policy-service · 2026-09-16T22:42:27Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Centralize string-discoverable Wasm thunk key generation and document the closed-static return-buffer signature predicates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

Fall back to an interpreted IL adapter when no pregenerated closed-static return-buffer thunk exists, and apply the ABI predicate independently of ReadyToRun. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

azure-pipelines · 2026-09-17T00:54:57Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

When no pregenerated closed-static return-buffer thunk is registered, keep the target entrypoint and rely on INTOP_CALLDELEGATE's inline closed-static dispatch instead of generating an IL stub. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

Copilot

Copilot review overview

🔵 Needs a closer look

The unresolved critical fallback-stub preparation concern and moderate test-coverage gap make automated approval unsafe.

Review effort: Lite
Findings: None

What changed in this PR

This PR fixes CoreCLR WebAssembly ReadyToRun closed static delegates returning aggregate structs by adding return-buffer argument shuffling.

Changes:

Adds runtime IL fallback adapters and portable entrypoint support.
Emits and roots signature-shared Crossgen2 WebAssembly thunks.
Expands R2R, interpreted, generic, and dynamic delegate regression coverage.

File	Summary
`src/tests/readytorun/wasm/WasmInterpreterTransitions/WasmInterpreterTransitions.cs`	Adds delegate regression coverage. Moderate: fallback tests should validate captured object references in returned structs.
`src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DelegateTests.cs`	Verifies delegate metadata, identity, equality, and object-reference returns.
`src/coreclr/vm/wasm/helpers.hpp`	Declares Wasm return-buffer classification and thunk lookup helpers.
`src/coreclr/vm/wasm/helpers.cpp`	Implements Wasm signature classification and thunk lookup.
`src/coreclr/vm/precode_portable.hpp`	Adds portable closed-static thunk entrypoint storage.
`src/coreclr/vm/method.hpp`	Adds the new IL stub type.
`src/coreclr/vm/ilstubcache.cpp`	Registers and names the new stub type.
`src/coreclr/vm/fptrstubs.h`	Adds adapter cache declarations.
`src/coreclr/vm/fptrstubs.cpp`	Implements adapter caching.
`src/coreclr/vm/dllimport.h`	Adds related stub flags and classification support.
`src/coreclr/vm/comdelegate.cpp`	Selects, creates, and caches adapters. Critical: prepare dynamic IL stubs before caching their addresses; nit: remove the dead null branch.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs`	Roots thunk dependencies for relevant signatures.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/ILCompiler.ReadyToRun.csproj`	Includes the new thunk node. Nit: preserve alphabetical item ordering.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRunCodegenNodeFactory.cs`	Caches and roots generated thunks.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/WasmVirtualDispatchThunkNode.cs`	Uses shared lookup-key generation.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/WasmUnboxingStubNode.cs`	Uses shared lookup-key generation.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/WasmClosedStaticRetBufThunkNode.cs`	Emits the closed-static return-buffer thunk.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/StringDiscoverableAssemblyStubNode.cs`	Provides shared Wasm lookup-key generation.
`src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DelegateCtorSignature.cs`	Roots thunks for delegate constructor signatures.

lewing · 2026-09-17T01:09:38Z

More cleanup coming - Done

Root closed-static return-buffer thunks only from compiled call sites, remove creation-only tests that no longer discriminate correctness, and leave interpreter fallbacks uncached for later R2R module registration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

Copilot

Copilot review overview

🟡 Changes recommended

Critical issues remain in Wasm thunk ordering and unmanaged-signature adapter classification.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2

Open (2)

Place D thunk after existing transition and virtual thunks · New
Avoid closed static retbuf thunks for unmanaged signatures · New

Resolved since last review (1)

Avoid retaining pending adapters when ReadyToRun is disabled

Remove the unused pending-resolution wrapper, preserve Wasm function-table ordering for the D thunk, and use standard contracts for the resolution-only call chain. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

Copilot

Copilot review overview

🔵 Needs a closer look

The broad runtime/AOT/Wasm change has a moderate (1-vote) request for a checked-in cross-loader regression and warrants human approval.

Review effort: Lite
Findings: 1

Open (1)

Avoid closed static retbuf thunks for unmanaged signatures

Resolved since last review (1)

Place D thunk after existing transition and virtual thunks

lewing · 2026-09-23T20:53:41Z

this code should be updated to use GetClosedStaticDelegateTargetSignatureonce #134497 lands

pavelsavara · 2026-09-25T10:29:54Z

It would we also good to add the shapes that this fixes into src/tests/readytorun/wasm/WasmInterpreterTransitions/WasmInterpreterTransitions.cs

And maybe also into src/tests/readytorun/wasm/WasmInterpreterTransitions/echo.c after #134355 lands. Does this PR impact/enable native C ABI too ?

lewing · 2026-09-25T16:03:52Z

Thanks. WasmInterpreterTransitions already has the managed closed-static shapes added by this PR: ObjectPairTargetExtensions.GetPair returning a struct with two object references, the S8/S12 argument-layout collision returning S16, runtime-generated targets, and recycled dynamic targets. The D adapter specifically reorders (capturedTarget, retbuf) into the managed static target's (retbuf, capturedTarget) order; it doesn't change the native C ABI.

The adapter can precede a managed-callable P/Invoke stub. I verified that locally with a native-linked closed P/Invoke delegate returning a 16-byte blittable struct: the D adapter returned the expected fields, while temporarily bypassing it returned corrupted fields. That's a useful separate end-to-end case we could put alongside echo.c once #134355 provides the native test asset path, but it isn't a native-to-UCO reverse callback. #134355 currently rejects UCO exports with hidden return buffers, so its existing C -> UCO echo path cannot exercise the ObjectPair/retbuf case without additional native-ABI support.

Note

This reply was generated with GitHub Copilot assistance.

Consume GetClosedStaticDelegateTargetSignature from dotnet#134497 for the closed-static retbuf thunk dependency, removing the duplicate signature construction. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd5418a9-09c6-4017-a1e1-edb2cf396b39

lewing · 2026-09-25T17:05:20Z

this code should be updated to use GetClosedStaticDelegateTargetSignatureonce #134497 lands

done

Copilot

Copilot review overview

🔵 Needs a closer look

Automated coverage is still needed for cross-loader resolution ordering and registration-failure retry.

Review effort: Lite
Findings: None

Resolved since last review (1)

Avoid closed static retbuf thunks for unmanaged signatures

…4611) ## Summary Browser-Wasm CoreCLR ReadyToRun skipped delegate-constructor lowering. Wasm can't use the dynamically composed `READYTORUN_DELEGATE_CTOR` helpers, and because ReadyToRun is `IsAot()`, it also skipped the `GetDelegateCtor` path the JIT uses. As a result, every `new D(target, ftn)` called the original runtime-implemented `.ctor(object, native int)` through the interpreter. With this change, Wasm ReadyToRun uses the same `GetDelegateCtor` transformation as the JIT. Crossgen2 selects the CoreLib constructor: | Selected constructor | Used for | |---|---| | `Delegate.CtorClosed` | Closed instance targets on reference types, with the same explicit arity as `Invoke` (including virtual and generic targets) | | `Delegate.DelegateConstruct` | Every other shape | - `DelegateConstruct` is the managed method the runtime already maps every delegate constructor to (`ecall.cpp`), so the fallback matches today's behavior for all shapes. - The `CtorClosed` shapes match those for which `COMDelegate::GetDelegateCtor` picks `CtorClosed`. The caller has already resolved the method pointer (`ldftn`/`ldvirtftn`, including instantiating stubs), so `CtorClosed` only stores the target and the pointer. - Generated code references the two CoreLib methods by name, the same way runtime async references `AsyncHelpers` methods such as `RestoreInlinedFrameContexts`. The JIT synthesizes these calls, so the caller's IL has no token for them. Crossgen2 therefore pre-seeds their manifest tokens, mirroring `AddNecessaryAsyncReferences`. ## Changes - **`flowgraph.cpp`:** - On `TARGET_WASM`, the ReadyToRun branch of `fgOptimizeDelegateConstructor` is taken only for NativeAOT, so Wasm ReadyToRun falls through to `GetDelegateCtor`. - After retargeting the call, the AOT entry point is recomputed with `getFunctionEntryPoint`, because the importer cached the original constructor's entry point. - Non-Wasm targets and NativeAOT are unchanged. - **Crossgen2:** - `GetDelegateCtor` is implemented in the ReadyToRun partial; the RyuJit partial throws `NotImplementedException`, as before. - Manifest tokens for `CtorClosed` and `DelegateConstruct` are seeded lazily on Wasm. - No R2R format, JIT-EE interface, or VM changes. The image version stays 30.0. ## Validation Local runs on macOS arm64, branch merged with current `main`: - **Builds:** Crossgen2, the cross-targeting Wasm JIT, the osx JIT and SuperPMI; browser-Wasm `clr+libs+host+packs` Release. - **Image tests:** `ILCompiler.ReadyToRun.Tests` with the Wasm target: 123 passed, 0 failed. `WasmDelegateConstructors` asserts that no `DelegateCtor` fixups remain and that both CoreLib constructors are imported. - **Runtime test:** `readytorun/wasm/WasmInterpreterTransitions` passes in these configurations: | Configuration | Result | |---|---| | Composite (harness default; CoreLib outside the bubble) | Pass; also passes with `DOTNET_GCStress=0xC` | | Per-assembly, no cross-module inlining | Pass; also passes with `DOTNET_GCStress=0xC` | | Per-assembly with `--opt-cross-module:*` | Pass; `CtorClosed` is inlined under a `CHECK_IL_BODY`/`VERIFY_IL_BODY` fixup, and the inlined null-receiver throw calls the private CoreLib helper through a manifest reference | | Composite with `--inputbubble` | Pass | It covers the open static, open instance (via an IL helper), closed instance, closed static, virtual (including a derived override), generic owner, shared and unshared generic method, and null-receiver shapes, plus open- and closed-static retbuf shapes. Each is value-checked, with `Target`/`Method` identity and repeated construction. - **Image dumps:** - The composite and per-assembly images call both constructors through `METHOD_ENTRY_REF_TOKEN` manifest references. - CoreLib still contains compiled bodies for both constructors without any extra rooting. - **Other:** `jitformat` and `git diff --check`; independent code review with no findings. ## Performance 100,000 constructions per sample; median of 3 runs × 4 samples, from the same build: | Shape | Interpreter only | R2R | R2R + `--opt-cross-module:*` | |---|---:|---:|---:| | Open static | 9.83 ms | **6.61 ms** | 6.55 ms | | Closed instance | 6.15 ms | **2.50 ms** | 2.22 ms | Before this change, R2R construction took ~44–46 ms for both shapes in an earlier build (directional only). Open static might get faster later from a dedicated `CtorOpen` path, which would need the shuffle thunk and collectible data; that would be a follow-up. ## Related work - #134108 (merged): the closed-static struct-return invocation adapter, now exercised by the runtime test. - #134497 (merged): complementary coverage of closed-static target interpreter thunks. Resolves #134564 > [!NOTE] > This pull request description was generated with GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4dd9dfb0-13d5-4a8c-9419-3f808cbd9b8b

github-actions Bot added the area-ReadyToRun label Sep 16, 2026

lewing requested review from AndyAyersMS and davidwrighton September 16, 2026 22:07

dotnet-policy-service Bot assigned lewing Sep 16, 2026

lewing added the arch-wasm WebAssembly architecture label Sep 16, 2026

davidwrighton reviewed Sep 16, 2026

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs

davidwrighton reviewed Sep 16, 2026

View reviewed changes

Comment thread src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs

davidwrighton reviewed Sep 16, 2026

View reviewed changes

Comment thread ...ompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/WasmClosedStaticRetBufThunkNode.cs Outdated

davidwrighton reviewed Sep 16, 2026

View reviewed changes

Comment thread ...ompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/WasmClosedStaticRetBufThunkNode.cs Outdated

MichalPetryka reviewed Sep 16, 2026

View reviewed changes

Comment thread src/coreclr/vm/comdelegate.cpp

jkotas reviewed Sep 17, 2026

View reviewed changes

Comment thread src/coreclr/vm/comdelegate.cpp Outdated

jkotas reviewed Sep 17, 2026

View reviewed changes

Comment thread src/coreclr/vm/comdelegate.cpp Outdated

lewing marked this pull request as ready for review September 17, 2026 00:54

Copilot AI lite review requested due to automatic review settings September 17, 2026 00:54

Copilot started reviewing on behalf of lewing September 17, 2026 00:55 View session

jkotas reviewed Sep 17, 2026

View reviewed changes

Comment thread src/coreclr/vm/comdelegate.cpp Outdated

jkotas reviewed Sep 17, 2026

View reviewed changes

Comment thread src/coreclr/vm/comdelegate.cpp Outdated

Copilot AI reviewed Sep 17, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 17, 2026 01:06

Copilot started reviewing on behalf of lewing September 17, 2026 01:07 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread ...ompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/WasmClosedStaticRetBufThunkNode.cs Outdated

Comment thread src/coreclr/vm/comdelegate.cpp

jkotas reviewed Sep 21, 2026

View reviewed changes

Comment thread src/coreclr/vm/pregeneratedstringthunks.cpp Outdated

jkotas reviewed Sep 21, 2026

View reviewed changes

Comment thread src/coreclr/vm/pregeneratedstringthunks.cpp Outdated

Copilot AI review requested due to automatic review settings September 21, 2026 23:30

Copilot started reviewing on behalf of lewing September 21, 2026 23:31 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

pavelsavara mentioned this pull request Sep 23, 2026

[wasm][R2R] Root interpreter thunks for closed static delegate targets #134497

Merged

This was referenced Sep 24, 2026

[wasm][coreclr][R2R] Delegate construction skips alternate-constructor lowering and remains interpreted #134564

Closed

[wasm] Use GetDelegateCtor for CoreCLR R2R delegate construction #134611

Merged

lewing requested review from davidwrighton and jkotas September 25, 2026 16:05

Copilot AI review requested due to automatic review settings September 25, 2026 17:01

Copilot started reviewing on behalf of lewing September 25, 2026 17:02 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

lewing requested review from BrzVlad and pavelsavara September 25, 2026 18:47

davidwrighton approved these changes Sep 25, 2026

View reviewed changes

lewing enabled auto-merge (squash) September 25, 2026 19:25

lewing merged commit 181b7ea into dotnet:main Sep 25, 2026
148 of 150 checks passed

build-analysis Bot mentioned this pull request Sep 25, 2026

Async2TaskAdapters.TestValueTaskOfTaskValueVersusAsync fails with SanityCheck() in Wasm R2R test #133953

Open

dotnet-maestro Bot mentioned this pull request Sep 26, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#9783

Merged

dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 26, 2026

lewing mentioned this pull request Sep 29, 2026

[wasm][R2R] Fix generic context / async continuation order in Wasm interpreter thunks #134676

Merged

Conversation

lewing commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Approach

Validation

Uh oh!

azure-pipelines Bot commented Sep 16, 2026

Uh oh!

dotnet-policy-service Bot commented Sep 16, 2026

Uh oh!

dotnet-policy-service Bot commented Sep 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Sep 17, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

lewing commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

lewing commented Sep 23, 2026

Uh oh!

pavelsavara commented Sep 25, 2026

Uh oh!

lewing commented Sep 25, 2026

Uh oh!

lewing commented Sep 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lewing commented Sep 16, 2026 •

edited

Loading

lewing commented Sep 17, 2026 •

edited

Loading