Repository navigation
[release/8.0-staging] Disable RSA SHA1/384 signature tests on Android - #134070
Conversation
Co-authored-by: vcsjones <361677+vcsjones@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
A related Android RSA-384/SHA-1 verification test remains enabled and may still fail.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Disables known failing Android RSA SHA-1/RSA-384 tests related to issue #134002.
Changes:
- Marks
ExpectedSignature_SHA1_384as an Android active issue. - Marks
VerifySignature_SHA1_384as an Android active issue.
File summaries
| File | Summary |
|---|---|
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/SignVerify.cs |
Adds Android-specific issue annotations to two RSA-384/SHA-1 tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
Co-authored-by: vcsjones <361677+vcsjones@users.noreply.github.com>
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
|
Test-only change |
|
/ba-g failures are unrelated |
|
/backport to release/9.0-staging |
|
Started backporting to |
/cc @vcsjones @bartonjs
Customer Impact
Disabled tests for #134002. The actual fix would likely not meet the back port bar for .NET 8, so let's disable the tests on Android.
Regression
Testing
We're disabling tests for .NET 8.0 on Android that do not pass and the fix is unlikely to meet back port threshold.
Risk
None. Test-only disablement.