Skip to content

[release/8.0-staging] Disable RSA SHA1/384 signature tests on Android - #134070

Merged
bartonjs merged 2 commits into
release/8.0-stagingfrom
copilot/disable-signature-tests-android
Sep 16, 2026
Merged

bartonjs merged 2 commits into
release/8.0-stagingfrom
copilot/disable-signature-tests-android

Conversation

Copilot AI commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

/cc @vcsjones @bartonjs

Customer Impact

  • Customer reported
  • Found internally

Disabled tests for #134002. The actual fix would likely not meet the back port bar for .NET 8, so let's disable the tests on Android.

Regression

  • Yes
  • No

Testing

We're disabling tests for .NET 8.0 on Android that do not pass and the fix is unlikely to meet back port threshold.

Risk

None. Test-only disablement.

Co-authored-by: vcsjones <361677+vcsjones@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

@vcsjones
vcsjones marked this pull request as ready for review September 16, 2026 14:57
Copilot AI lite review requested due to automatic review settings September 16, 2026 14:57
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A related Android RSA-384/SHA-1 verification test remains enabled and may still fail.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Disables known failing Android RSA SHA-1/RSA-384 tests related to issue #134002.

Changes:

  • Marks ExpectedSignature_SHA1_384 as an Android active issue.
  • Marks VerifySignature_SHA1_384 as an Android active issue.
File summaries
File Summary
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/SignVerify.cs Adds Android-specific issue annotations to two RSA-384/SHA-1 tests.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Copilot AI commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install Dependencies

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@vcsjones vcsjones changed the title Disable RSA SHA1/384 signature tests on Android [release/8.0-staging] Disable RSA SHA1/384 signature tests on Android Sep 16, 2026
Co-authored-by: vcsjones <361677+vcsjones@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 16, 2026 15:13
Copilot AI requested a review from vcsjones September 16, 2026 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed changes are test-only Android disablements with no unresolved blocking issues.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install Dependencies

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

@bartonjs bartonjs added test-enhancement Improvements of test source code Servicing-approved Approved for servicing release labels Sep 16, 2026
@bartonjs

Copy link
Copy Markdown
Member

Test-only change

@bartonjs
bartonjs enabled auto-merge (squash) September 16, 2026 16:48
@vcsjones

Copy link
Copy Markdown
Member

/ba-g failures are unrelated

@bartonjs
bartonjs merged commit b8a502b into release/8.0-staging Sep 16, 2026
122 of 131 checks passed
@bartonjs
bartonjs deleted the copilot/disable-signature-tests-android branch September 16, 2026 18:31
@vcsjones

Copy link
Copy Markdown
Member

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security Servicing-approved Approved for servicing release test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants