Repository navigation
Invoke debugger function evaluations through managed UCO - #133659
Open
jkoritzinsky wants to merge 24 commits into
Open
jkoritzinsky wants to merge 24 commits into
jkoritzinsky wants to merge 24 commits into
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 11, 2026
jkoritzinsky
removed this pull request from stack #133661
September 11, 2026 03:11
jkoritzinsky
added this pull request to stack #133663
September 11, 2026 03:11
Contributor
|
Tagging subscribers to this area: @agocke |
3 tasks
Member
This was referenced Sep 11, 2026
jkoritzinsky
force-pushed
the
dev/jkoritzinsky/func-eval-uco
branch
2 times, most recently
from
September 13, 2026 15:15
08c8a1d to
2c9232c
Compare
This was referenced Sep 13, 2026
Closed
jkoritzinsky
force-pushed
the
dev/jkoritzinsky/func-eval-uco
branch
from
September 15, 2026 00:28
2c9232c to
84969d7
Compare
Member
Author
jkoritzinsky
force-pushed
the
dev/jkoritzinsky/func-eval-uco
branch
from
September 15, 2026 21:55
84969d7 to
ce9480a
Compare
jkoritzinsky
force-pushed
the
dev/jkoritzinsky/func-eval-uco
branch
from
September 15, 2026 22:57
ce9480a to
10d25d9
Compare
The writable copy is performed by PackArgumentStorage. The residual copy in GetFuncEvalArgStorage references parameters removed by the managed func-eval refactor. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use debugger-specific emitted thunks for managed argument preparation, invocation, and copy-back. Retain native GC-safe input capture and debugger state handling, protect result and snapshot storage with external memory handles, and preserve reference identity and fresh external-value inspection across collections. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Register known references in serialized non-leaf register slots with external memory handles before managed entry. Read register-only value types from those GC-updated slots, while preserving native snapshots for leaf and mixed homes and leaving numeric register contents unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run preparation, invocation, and copy-back within a single managed UCO entry. Use GCFrameRegistration for call storage, and move primitive capture, result handle creation, and memory/literal copy-back into CoreLib while retaining native bootstrap, register, and completion responsibilities. Avoid the invalid cooperative-mode safe-point query uncovered by GCStress validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the debugger-specific allocator QCall with RuntimeTypeHandle.InternalAllocNoChecks after activating each type at its actual allocation site. Preserve COM, GCStress, logging, large/finalizable object, and profiler/ETW behavior by falling back to the existing slow allocator when required. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Treat RAK_MEMREG and RAK_REGMEM as scalar 64-bit integer or enum homes rather than hypothetical GC-containing structs. Remove their GC-layout rooting and address registrations, retain scalar snapshots and copy-back, reduce the external-handle bound, and assert the verified invariant. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Register DebuggerEval::m_result[0] directly as the persistent interior root for raw byref returns. Tie root ownership to DebuggerEval cleanup, remove the refresh/controller ownership path, and unregister before exception publication repurposes the slot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Report the MethodTable loader allocator during external-memory root promotion and remove the redundant debugger typed-owner allocator handle. Preserve the separate raw-byref result lifetime root. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Represent external memory with the exact managed local type, including byrefs and unmanaged pointers. Update runtime callers, cDAC descriptors, root walking, tests, and contract documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: am11 <3840695+am11@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This reverts commit cc83a28cb5e01c0c58ff4b73bef5423681110560. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use InternalAlloc and GC-aware raw nullable copying while preserving heap-backed argument storage. Remove the dedicated EnsureInstanceActive QCall. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fix temporary result ownership and external-field lifetimes, including helper-thread cleanup. Preserve receiver semantics, correct floating-register handling and restrict raw reference inputs to pointer-sized integers. Make cDAC root parity validation duplicate-safe, add targeted coverage, clarify argument storage, and restore the original unchecked allocation fast path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Hide debugger invocation thunks consistently in native and cDAC stack walks. Validate argument counts before managed entry and preserve abstract-class initialization requests by returning null without instance construction. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the debugger invocation MethodDesc global into the always-linked VM exception-handling implementation. Preserve debugger publication and allow the WASM comparison to remain a null no-op without linking the debugger EE. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add matching native DAC and cDAC classifications requiring both LCG and explicit diagnostics-hidden flags. Suppress only that class in synchronous stack walks, preserving interop stitching and older shim/async hiding behavior. Update contract documentation and regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jkoritzinsky
force-pushed
the
dev/jkoritzinsky/func-eval-uco
branch
from
October 14, 2026 21:01
124d5e9 to
e9b674c
Compare
Drop the stale debug-only assignment to removed argument-location bookkeeping while preserving the interpreter raw-slot object-reference handling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jkotas
reviewed
Oct 15, 2026
| { | ||
| WRAPPER_NO_CONTRACT; | ||
|
|
||
| // Explicit layout can declare the same physical byref more than once. |
Member
There was a problem hiding this comment.
This fix should be submitted as a separate PR with a targeted regression test. It is not a debugger specific issue. For example, the following is expected to print 1 2 3 4, but it prints bogus numbers on win x86 with DOTNET_GCStress=1 .
using System;
using System.Runtime.InteropServices;
X x = default;
x.a.a = new int[10]; x.a.a.Fill(1);
x.a.b = new int[10]; x.a.b.Fill(2);
x.a.c = new int[10]; x.a.c.Fill(3);
x.a.d = new int[10]; x.a.d.Fill(4);
Test(x);
static void Test(X x)
{
Console.WriteLine(x.a.a[0]);
Console.WriteLine(x.a.b[0]);
Console.WriteLine(x.a.c[0]);
Console.WriteLine(x.a.d[0]);
}
ref struct A
{
public Span<int> a,b,c,d;
}
ref struct B
{
public Span<int> a,b,c,d;
}
[StructLayout(LayoutKind.Explicit)]
ref struct X
{
[FieldOffset(0)]
public A a;
[FieldOffset(0)]
public A b;
}
jkotas
reviewed
Oct 15, 2026
| for (OverlappingFields* overlap = _overlappingFields; overlap != nullptr; overlap = overlap->previous) | ||
| { | ||
| ApproxFieldDescIterator fields(overlap->methodTable, ApproxFieldDescIterator::INSTANCE_FIELDS); | ||
| for (FieldDesc* field = fields.Next(); field != overlap->currentField; field = fields.Next()) |
Member
There was a problem hiding this comment.
This is quadratic algorithm that can take a while if somebody created large ExplicitLayout struct. It is probably ok given that this should be a very rare situation and large structs have sharp edges in general, just pointing it out. It may be worth a comment
jkotas
reviewed
Oct 15, 2026
| DllImportEntry(DebugDebugger_CustomNotification) | ||
| DllImportEntry(DebugDebugger_IsLoggingHelper) | ||
| DllImportEntry(DebugDebugger_IsManagedDebuggerAttached) | ||
| #if defined(DEBUGGING_SUPPORTED) && !defined(TARGET_WASM) |
Member
There was a problem hiding this comment.
Suggested change
| #if defined(DEBUGGING_SUPPORTED) && !defined(TARGET_WASM) | |
| #if defined(DEBUGGING_SUPPORTED) |
Use DEBUGGING_SUPPORTED consistently for debugger layouts, native declarations and QCall registrations. Provide explicit PORTABILITY_ASSERT-only WASM stubs until its debugger EE implementation is built. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 3 of the stack for #123864, following #133658. The prior func-eval-specific proposal is #126809.
This layer started as replacing the final native managed-call dispatch with a managed UnmanagedCallersOnly entrypoint. It now moves most debugger function-evaluation preparation, invocation, storage, and copy-back into managed CoreLib while retaining the debugger-specific control flow and GC-safe bootstrap in native code.
Managed invocation and storage
Debugger.FunctionEvaluation, a runtime-owned UCO entrypoint that resolves the exact target method from its declaringRuntimeTypeand rootedIRuntimeMethodInfo.newobjfor debugger object construction instead of preallocating an object and calling its constructor as an ordinary method. Existing-object constructor calls remain supported, and abstract/interface allocation is rejected.GCFrameRegistration, using exact typed locals for memory-backed by-value ref structs so their managed byrefs are reported by normal JIT GC info.Native debugger and GC integration
ExternalMemoryHandleregistrations so collections during managed preparation relocate their contents correctly.TypeHandle, allowing the runtime and cDAC to distinguish inline value types, object-reference slots, managed-byref slots, and unmanaged pointer/function-pointer locals.debug/ee.Correctness fixes included
ref structwith overlappingreffields is reported to the GC twice, so a compacting GC relocates the byref twice #135245).Validation
Validation used the existing internal MDbg/xUnit debugger-test harness with a private CoreRun and ProjectK/CoreCLR-only configuration:
GCStress=0x3: 1/1 passed.Coverage includes moving GC, overlapping and nested byrefs, memory and register homes, non-leaf registers, receiver mutation, constructors, primitive/native-endian copy-back, nullable memory homes, byref/byref-like/value-type results, collectible generics and layouts, nested and exception-time eval, safe/rude/exception-unwind aborts, and post-eval inspection. Runtime hashes and loaded modules were audited; each abort scenario completed the callback, successfully evaluated
Echo(42), detached, and exited MDbg with code 100. Test configurations were restored and no debugger/test processes survived the runs.These results were recorded on the validated pre-refresh candidate. The final stack rebase preserved the layer's net diff; builds and tests were not repeated after the history rewrite at the user's request.
The final native invocation cleanup layer is #133660.
Stack created with GitHub Stacks CLI • Give Feedback 💬
Resolves #135245
Resolves #135247
Resolves #135249
Resolves #135251
Resolves #135252
Note
This PR description and implementation were prepared with GitHub Copilot. Commits that reuse am11's code retain the requested co-author attribution.