Restore isolation for GC Collect tests - #132076
Merged
Merged
Conversation
These tests depend on process-wide GC state and cannot run reliably in the merged test runner. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7186616-baa4-46ff-8c5e-2571610a7219
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
kkokosa
marked this pull request as ready for review
August 10, 2026 13:21
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Restores per-test process isolation for the GC Collect, Collect0, and Collect1 test projects so their generation assertions run with uncontested, process-wide GC state (preventing cross-test GC-state leakage in merged runners).
Changes:
- Re-added
<RequiresProcessIsolation>true</RequiresProcessIsolation>toCollect,Collect0, andCollect1test project files. - Documented the isolation requirement inline in each project file with a brief rationale comment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/GC/API/GC/Collect.csproj | Restores process isolation for the Collect test project to avoid shared-process GC state interference. |
| src/tests/GC/API/GC/Collect0.csproj | Restores process isolation for the Collect0 test project to ensure GC generation checks are reliable. |
| src/tests/GC/API/GC/Collect1.csproj | Restores process isolation for the Collect1 test project to prevent contamination from prior tests in merged runners. |
jkoritzinsky
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131721
Fixes #131893
PR #126108 removed process isolation from
Collect,Collect0, andCollect1, allowing their generation assertions to observe GC state accumulated by earlier tests in the merged runner. Restore isolation because these tests require uncontested process-wide GC state.Local x86 Checked investigation reproduced all three failures by accumulating leaked pinned handles in a shared process. The same failures occurred under FullOpt, while target-only runs, runs excluding
AddrOfPinnedObject, and pin-and-free controls completed 10,000 iterations without failure, so this change preserves JIT-mode coverage instead of marking the testsJitOptimizationSensitive.Validation:
Collect,Collect0, andCollect1wrappersNote
This pull request description was prepared with GitHub Copilot.