Fix SuppressGCTransitionNegativeTest: restore GCStressIncompatible, document CLRTestExitCode requirement - #131670
Merged
Merged
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…d of SkipOnCoreClr The test sets CLRTestExitCode to a crash exit code, so an XUnit-level skip (which returns 100) conflicts with the expected exit code. Use the process-level GCStressIncompatible mechanism instead. Also document this requirement in requiresprocessisolation.md. Fixes #131667 Co-authored-by: jkoritzinsky <1571408+jkoritzinsky@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Copilot
AI
changed the title
[WIP] Fix failed test for SuppressGCTransitionNegativeTest
Fix SuppressGCTransitionNegativeTest: restore GCStressIncompatible, document CLRTestExitCode requirement
Jul 31, 2026
jkoritzinsky
approved these changes
Jul 31, 2026
jkoritzinsky
marked this pull request as ready for review
July 31, 2026 20:04
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jkotas
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuppressGCTransitionNegativeTestwas failing under GC stress withExpected: -2146233082 / Actual: 100. PR #126108 replaced<GCStressIncompatible>true</GCStressIncompatible>with[SkipOnCoreClr(..., RuntimeTestModes.AnyGCStress)], but this test has a non-defaultCLRTestExitCode(crash exit code). An XUnit-level skip returns 100, which conflicts with the expected crash exit code the harness checks.SuppressGCTransitionNegativeTest.csproj: Restore<GCStressIncompatible>true</GCStressIncompatible>so GC stress skipping happens at the wrapper-script level, not inside XUnit.SuppressGCTransitionNegativeTest.cs: Remove the[SkipOnCoreClr]attribute that caused the XUnit-level skip.requiresprocessisolation.md: Add Rule 30 — tests with a non-defaultCLRTestExitCodemust use process-level skip mechanisms (e.g.,GCStressIncompatible) rather than XUnit-level attributes; also addCLRTestExitCodeto the summary table.Note
This description was generated with AI assistance.