Add test coverage for UnmanagedCallersOnly with CallConvFastcall (Windows-only) by Copilot · Pull Request #130632 · dotnet/runtime

Copilot · 2026-07-13T16:11:03Z

This pull request updates the unmanaged calling convention interop tests to support and validate calling managed methods with multiple parameters using Stdcall, Cdecl, and, on Windows, Fastcall. The changes expand the callback signatures to accept three integer parameters, update the corresponding native and managed method declarations, and add new tests for the Fastcall convention.

All new tests are gated with [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))].

…dows-only) Adds the following tests: - UnmanagedCallersOnlyTest.cs: TestUnmanagedCallersOnlyViaUnmanagedCalli_Fastcall - tests a managed callback with [UnmanagedCallersOnly(CallConvs = [typeof(CallConvFastcall)])] called via a delegate* unmanaged[Fastcall] pointer (Windows-only) - UnmanagedCallersOnlyDll.cpp: CallManagedProc_Fastcall native function (guarded by #ifdef _WIN32) - UnmanagedCallersOnlyBasicTest.cs: TestUnmanagedCallersOnlyValid_CallConvFastcall - tests a managed callback invoked from native code using the fastcall calling convention (Windows-only) Closes #110760 Co-authored-by: AaronRobinsonMSFT <30635565+AaronRobinsonMSFT@users.noreply.github.com>

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

AaronRobinsonMSFT · 2026-07-13T16:44:47Z

/cc @elinor-fung @jtschuster @MichalStrehovsky

dotnet-policy-service · 2026-07-13T16:45:05Z

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 2

…efactor callback methods

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 2

…anagedCallersOnly tests

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 0 new

AaronRobinsonMSFT · 2026-07-15T20:09:01Z

/ba-g Unrelated failures.

Initial plan

9af5496

Copilot AI assigned Copilot and AaronRobinsonMSFT Jul 13, 2026

Copilot AI requested review from Copilot and removed request for Copilot July 13, 2026 16:11

github-project-automation Bot added this to AppModel Jul 13, 2026

Copilot started work on behalf of AaronRobinsonMSFT July 13, 2026 16:12 View session

Copilot AI linked an issue Jul 13, 2026 that may be closed by this pull request

Missing test coverage for UnmanagedCallersOnly with CallconvFastcall #110760

Closed

Copilot AI temporarily deployed to copilot-pat-pool July 13, 2026 16:16 Inactive

github-actions Bot added the area-Infrastructure label Jul 13, 2026

github-project-automation Bot added this to Runtime Infra Jul 13, 2026

Copilot AI temporarily deployed to copilot-pat-pool July 13, 2026 16:17 Inactive

Copilot AI requested review from Copilot and removed request for Copilot July 13, 2026 16:36

Copilot AI changed the title ~~[WIP] Add missing test coverage for UnmanagedCallersOnly with CallconvFastcall~~ Add test coverage for UnmanagedCallersOnly with CallConvFastcall (Windows-only) Jul 13, 2026

Copilot finished work on behalf of AaronRobinsonMSFT July 13, 2026 16:37

Copilot AI requested a review from AaronRobinsonMSFT July 13, 2026 16:37

AaronRobinsonMSFT reviewed Jul 13, 2026

View reviewed changes

Comment thread src/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyTest.cs Outdated

Apply suggestions from code review

0068074

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

Copilot AI review requested due to automatic review settings July 13, 2026 16:43

AaronRobinsonMSFT temporarily deployed to copilot-pat-pool July 13, 2026 16:43 — with GitHub Actions Inactive

AaronRobinsonMSFT marked this pull request as ready for review July 13, 2026 16:43

AaronRobinsonMSFT temporarily deployed to copilot-pat-pool July 13, 2026 16:44 — with GitHub Actions Inactive

AaronRobinsonMSFT added area-Interop-coreclr and removed area-Infrastructure labels Jul 13, 2026

Copilot started reviewing on behalf of AaronRobinsonMSFT July 13, 2026 16:44 View session

AaronRobinsonMSFT added this to the 11.0.0 milestone Jul 13, 2026

AaronRobinsonMSFT temporarily deployed to copilot-pat-pool July 14, 2026 13:04 — with GitHub Actions Inactive

Copilot started reviewing on behalf of AaronRobinsonMSFT July 14, 2026 13:04 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/tests/Interop/UnmanagedCallersOnlyBasic/UnmanagedCallersOnlyBasicTest.cs Outdated

Comment thread src/tests/Interop/UnmanagedCallersOnlyBasic/UnmanagedCallersOnlyBasicTest.cs

This was referenced Jul 14, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

Add support for Stdcall callbacks in UnmanagedCallersOnly tests and r…

c4ae37c

…efactor callback methods

Copilot AI review requested due to automatic review settings July 14, 2026 19:55

AaronRobinsonMSFT temporarily deployed to copilot-pat-pool July 14, 2026 19:55 — with GitHub Actions Inactive

Copilot started reviewing on behalf of AaronRobinsonMSFT July 14, 2026 19:55 View session

AaronRobinsonMSFT requested a review from jtschuster July 14, 2026 19:57

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/tests/Interop/UnmanagedCallersOnly/UnmanagedCallersOnlyDll.cpp Outdated

Comment thread src/tests/Interop/UnmanagedCallersOnlyBasic/UnmanagedCallersOnlyBasicTest.cs Outdated

Remove redundant Stdcall implementation and tidy up formatting in Unm…

8490d42

…anagedCallersOnly tests

Copilot AI review requested due to automatic review settings July 14, 2026 20:01

AaronRobinsonMSFT temporarily deployed to copilot-pat-pool July 14, 2026 20:01 — with GitHub Actions Inactive

Copilot started reviewing on behalf of AaronRobinsonMSFT July 14, 2026 20:02 View session

AaronRobinsonMSFT temporarily deployed to copilot-pat-pool July 14, 2026 20:02 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

jtschuster approved these changes Jul 14, 2026

View reviewed changes

AaronRobinsonMSFT enabled auto-merge (squash) July 14, 2026 23:00

MichalStrehovsky approved these changes Jul 15, 2026

View reviewed changes

AaronRobinsonMSFT merged commit 4428ba1 into main Jul 15, 2026
84 of 90 checks passed

AaronRobinsonMSFT deleted the copilot/add-test-coverage-unmanagedcallersonly branch July 15, 2026 20:09

github-project-automation Bot moved this to Done in Runtime Infra Jul 15, 2026

github-project-automation Bot moved this to Done in AppModel Jul 15, 2026

dotnet-maestro Bot mentioned this pull request Jul 16, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#7778

Merged

dotnet-milestone-bot Bot modified the milestones: 11.0.0, 11.0-preview7 Jul 16, 2026

github-actions Bot locked and limited conversation to collaborators Aug 16, 2026

Navigation Menu

Uh oh!

Add test coverage for UnmanagedCallersOnly with CallConvFastcall (Windows-only) - #130632

Add test coverage for UnmanagedCallersOnly with CallConvFastcall (Windows-only)#130632
AaronRobinsonMSFT merged 9 commits into
mainfrom
copilot/add-test-coverage-unmanagedcallersonly

Copilot AI commented Jul 13, 2026 •

edited by AaronRobinsonMSFT

Loading

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Jul 13, 2026 •

edited

Loading

Uh oh!

dotnet-policy-service Bot commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

AaronRobinsonMSFT commented Jul 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Copilot AI commented Jul 13, 2026 • edited by AaronRobinsonMSFT Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service Bot commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

AaronRobinsonMSFT commented Jul 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Jul 13, 2026 •

edited by AaronRobinsonMSFT

Loading

AaronRobinsonMSFT commented Jul 13, 2026 •

edited

Loading