Skip to content

[Wasm RyuJit] Use local's register type when loading it's value #127619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyAyersMS merged 2 commits into from
May 1, 2026
Merged

[Wasm RyuJit] Use local's register type when loading it's value #127619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f633570
[Wasm RyuJit] Use local's register type when loading it's value
AndyAyersMS Apr 30, 2026
449e993
review feedback
AndyAyersMS Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/coreclr/jit/codegenwasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2302,8 +2302,9 @@ void CodeGen::genCodeForLclVar(GenTreeLclVar* tree)
else
{
assert(genIsValidReg(varDsc->GetRegNum()));
unsigned wasmLclIndex = WasmRegToIndex(varDsc->GetRegNum());
GetEmitter()->emitIns_I(INS_local_get, emitTypeSize(tree), wasmLclIndex);
var_types type = varDsc->GetRegisterType(tree);
unsigned wasmLclIndex = WasmRegToIndex(varDsc->GetRegNum());
GetEmitter()->emitIns_I(INS_local_get, emitTypeSize(type), wasmLclIndex);
// In this case, the resulting tree type may be different from the local var type where the value originates,
// and so we need an explicit conversion since we can't "load"
// the value with a different type like we can if the value is on the shadow stack.
Expand Down
Loading