Align OTel names with general conventions. - #126451
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-caching |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.Extensions.Caching.Memory MemoryCache OpenTelemetry metric and attribute (tag) names to follow a dotnet.cache.* naming convention.
Changes:
- Renamed cache metric instrument names (e.g.,
cache.requests→dotnet.cache.requests). - Renamed metric tag keys (e.g.,
cache.name/cache.request.type→dotnet.cache.name/dotnet.cache.request.type). - Adjusted several metric unit strings (plural → singular).
karelz
marked this pull request as ready for review
April 2, 2026 17:01
karelz
marked this pull request as draft
April 2, 2026 17:05
karelz
approved these changes
Apr 2, 2026
cincuranet
marked this pull request as ready for review
April 3, 2026 14:27
cincuranet
enabled auto-merge (squash)
April 3, 2026 14:28
Contributor
Author
|
/ba-g unrelated |
This was referenced Apr 3, 2026
This was referenced Apr 3, 2026
Member
|
Would be good to get this documented in the Semantic Conventions for .NET. |
Contributor
Author
|
Yes. I'm planning to do it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #126146.