Repository navigation

Add new process management APIs to SafeProcessHandle - #124375

Closed

adamsitnik with Copilot wants to merge 59 commits into

mainfrom

copilot/add-new-apis-to-safeprocesshandle

Commits on Feb 11, 2026
- Initial plan
  Copilot
  committed
  4f3f950
- Add ProcessStartOptions class with path resolution and tests
  
  Copilot
  and
  adamsitnik
  committed
  92de299
- Fix build errors and test failures in ProcessStartOptions
  
  Copilot
  and
  adamsitnik
  committed
  0c9d3e2
- Improve code comments based on review feedback
  
  Copilot
  and
  adamsitnik
  committed
  794a8a2
- Fix exception documentation and add caching comment
  
  Copilot
  and
  adamsitnik
  committed
  a1b3426
- Address PR feedback: use Process.ResolvePath, fix tests, add null checks
  
  Copilot
  and
  adamsitnik
  committed
  10ff95a
- Refactor: ProcessStartOptions.ResolvePath as main impl, Process calls it
  
  Copilot
  and
  adamsitnik
  committed
  fc0fd30
- address my own feedback
  adamsitnik
  committed
  f687eb8
- Simplify Windows tests: remove ConditionalFact, fix nested try-finally
  
  Copilot
  and
  adamsitnik
  committed
  5459ec9
Commits on Feb 12, 2026
- Refactor tests: partial classes, remove Test prefix, use new() syntax, Theory for utils
  
  Copilot
  and
  adamsitnik
  committed
  c3517ee
- Fix test conditions: remove redundant IsWindows check, use GetFullPath for sh
  
  Copilot
  and
  adamsitnik
  committed
  bbea91e
- Fix test failures: use ResolveTarget helper for symlinks, fix lambda syntax
  
  Copilot
  and
  adamsitnik
  committed
  d9d381f
- Fix Unix test failures: use EndsWith instead of exact path comparison
  
  Copilot
  and
  adamsitnik
  committed
  b4d6e64
- Address code review: add file check, fix .exe logic, update comments, remove dead code
  
  Copilot
  and
  adamsitnik
  committed
  98d4201
- Cache Windows directory value for performance
  
  Copilot
  and
  adamsitnik
  committed
  5b024d4
- Remove DictionaryWrapper and fix Unix path test for macOS symlinks
  
  Copilot
  and
  adamsitnik
  committed
  add4af6
Commits on Feb 13, 2026
- Use Environment.SystemDirectory and fix Unix path test for macOS
  
  Copilot
  and
  adamsitnik
  committed
  b3939ad
- Inline GetSystemDirectory, fix Unix path test, use EndsWith for util names
  
  Copilot
  and
  adamsitnik
  committed
  63e7fc0
- Update src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
  adamsitnik
  authored
  9ceaad1
- fix the ResolvePath_UsesCurrentDirectory test
  adamsitnik
  committed
  82e2cec
- Merge remote-tracking branch 'origin/main' into copilot/add-processstartoptions-class
  adamsitnik
  committed
  0f37ab7
- Initial plan
  Copilot
  committed
  27ad99b
- Add ProcessExitStatus type, Windows interop files, and ProcessUtils
  
  Copilot
  and
  adamsitnik
  committed
  90ba788
- Add SafeProcessHandle new APIs, ProcessExitStatus, interop definitions, and Windows implementation
  
  Copilot
  and
  adamsitnik
  committed
  23a457a
- Add test files for SafeProcessHandle APIs
  
  Copilot
  and
  adamsitnik
  committed
  3017731
- Merge remote-tracking branch 'origin/main' into copilot/add-new-apis-to-safeprocesshandle
  adamsitnik
  committed
  fb6e0a4
- Address review feedback: consolidate interop files, reuse existing APIs, fix Win32Exception usage, improve tests
  
  Copilot
  and
  adamsitnik
  committed
  51bee9d
- fix the build
  adamsitnik
  committed
  2e5f817
Commits on Feb 16, 2026
- Fix bugs found during code review: remove CloseHandle on pseudo-handle, add wait after kill, validate timeout, remove dead code, use sizeof
  
  Copilot
  and
  stephentoub
  committed
  e65c2bf
- Add ReaderWriterLockSlim to prevent accidental handle inheritance between Process.Start and SafeProcessHandle.Start
  
  Copilot
  and
  adamsitnik
  committed
  5a26663
Commits on Feb 17, 2026
- Address jkotas feedback: simplify handle checks, fix OOM safety, fold catch into finally, rename interop file, fix coding conventions
  
  Copilot
  and
  adamsitnik
  committed
  180fc9b
Commits on Feb 18, 2026
Commits on Feb 26, 2026
- Changes before error encountered
  
  Copilot
  and
  adamsitnik
  committed
  a3f204c
- Make Resume, KillProcessGroup internal; replace ConditionalFact with Fact; add Nano Server support to CreateTenSecondSleep
  
  Copilot
  and
  adamsitnik
  committed
  af1336a
Commits on Feb 27, 2026
Commits on Feb 28, 2026
- address code review feedback:
  adamsitnik
  committed
  43906e8
Commits on Mar 1, 2026
- Merge remote-tracking branch 'origin/main' into copilot/add-new-apis-to-safeprocesshandle
  adamsitnik
  committed
  628053c
Commits on Mar 3, 2026
- Address jkotas feedback: fix safe handle races, use WaitForSingleObject directly, allow raw signal values, fix docs
  
  Copilot
  and
  adamsitnik
  committed
  e8a230b
Commits on Mar 4, 2026
- Merge branch 'main' into copilot/add-new-apis-to-safeprocesshandle
  stephentoub
  authored
  6fe2f5b
- address feedback
  adamsitnik
  committed
  c7c7176
Commits on Mar 6, 2026
- Apply suggestions from code review
  
  adamsitnik
  and
  jkotas
  authored
  f7ff001
- address code review feedback:
  adamsitnik
  committed
  8a1d8c8
- fix test failure
  adamsitnik
  committed
  399c84a
Commits on Mar 7, 2026
- Apply suggestions from code review
  
  adamsitnik
  and
  jkotas
  authored
  7b1f334
- take writer lock when InheritedHandles are provided
  adamsitnik
  committed
  6999b01
- Apply suggestions from code review
  adamsitnik
  authored
  2ec139f
Commits on Mar 9, 2026
- address code review feedback: update XML docs about InheritedHandles
  adamsitnik
  committed
  0a35881
Commits on Mar 13, 2026
Commits on Mar 16, 2026
- provide missing test coverage
  adamsitnik
  committed
  aa5e095
Commits on Mar 17, 2026
- address code review feedback:
  adamsitnik
  committed
  ba134f7
- Apply suggestions from code review
  adamsitnik
  authored
  3f5919d

Commits

Commits on Feb 11, 2026

Commits on Feb 12, 2026

Commits on Feb 13, 2026

Commits on Feb 16, 2026

Commits on Feb 17, 2026

Commits on Feb 18, 2026

Commits on Feb 26, 2026

Commits on Feb 27, 2026

Commits on Feb 28, 2026

Commits on Mar 1, 2026

Commits on Mar 3, 2026

Commits on Mar 4, 2026

Commits on Mar 6, 2026

Commits on Mar 7, 2026

Commits on Mar 9, 2026

Commits on Mar 13, 2026

Commits on Mar 16, 2026

Commits on Mar 17, 2026