Don't set security descriptor if the mutex is not owned/new - #120075
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a mutex access control issue by only setting security permissions when the mutex is newly created. The change prevents unnecessary access control modifications on existing mutexes.
- Only sets mutex access control when
createdNewis true - Adds conditional check around the existing security configuration code
- Maintains the same security model but applies it more selectively
github-actions
Bot
added
the
needs-area-label
jkotas
added
area-System.Diagnostics.EventLog
and removed
needs-area-label
jozkee
added
area-System.Diagnostics.PerformanceCounter
and removed
area-System.Diagnostics.EventLog
labels
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter |
jozkee
commented
Sep 25, 2025
jozkee
changed the title
ericstj
approved these changes
Sep 25, 2025
ericstj
left a comment
ericstj
left a comment
Member
There was a problem hiding this comment.
As discussed - you've done manual testing involving multiple users to ensure this is fixed. I imagine we cannot cover this easily in CI.
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18021213909 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116014.
Fixes #110454.