Skip to content

Add missing [RequiresDynamicCode] attributes to System.Linq.Expressions API in ref assembly #107580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 6 commits into from
Sep 10, 2024
Merged

Add missing [RequiresDynamicCode] attributes to System.Linq.Expressions API in ref assembly #107580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0b4d65
dotnet build /t:GenerateReferenceAssemblySource
cston Sep 9, 2024
59aceeb
Revert unnecessary changes
cston Sep 9, 2024
160fa48
Revert API changes
cston Sep 9, 2024
ea7955b
build ... /p:ApiCompatGenerateSuppressionFile=true
cston Sep 10, 2024
2375bea
Update link
cston Sep 10, 2024
519b16e
Resolve AOT warning in DependencyInjection ExpressionResolverBuilder
eerhardt Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...Extensions.DependencyInjection/src/ServiceLookup/Expressions/ExpressionResolverBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ internal sealed class ExpressionResolverBuilder : CallSiteVisitor<object?, Expre

private static readonly ParameterExpression CaptureDisposableParameter = Expression.Parameter(typeof(object));
private static readonly LambdaExpression CaptureDisposable = Expression.Lambda(
delegateType: typeof(Func<object?, object?>),

@eerhardt eerhardt Sep 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were getting AOT warnings in this code now that the ref assemblies were annotated correctly. This should be equivalent code. Linq.Expressions doesn't need to create the delegate implicitly now.

Expression.Call(ScopeParameter, ServiceLookupHelpers.CaptureDisposableMethodInfo, CaptureDisposableParameter),
CaptureDisposableParameter);

Expand Down
Loading