Skip to content

MsQuicStream can leak CancellationTokenRegistrations #69491

Description

@MihaZupan

While reading through #69483 I noticed that SetupWriteStartState creates a CancellationTokenRegistration, but the method may still throw, in which case the registration won't be disposed.

As a result the MsQuicStream.State will remain rooted by the (potentially user-provided) cancellation token.

cc: @rzikm @ManickaP

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions