Runtime fails to source build - libSystem.IO.Ports.Native.so.dbg not found

[MichaelSimons]

The runtime repo is failing to source build.

./build.sh -c Release --restore --build --pack /p:ArcadeBuildFromSource=true -bl

/repos/runtime/.dotnet/sdk/6.0.100-rc.1.21411.28/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5026: The file '/repos/runtime/artifacts/source-build/self/src/artifacts/bin/native/net6.0-Linux-Release-x64/libSystem.IO.Ports.Native.so.dbg' to be packed was not found on disk. [/repos/runtime/artifacts/source-build/self/src/src/libraries/System.IO.Ports/pkg/runtime.linux-x64.runtime.native.System.IO.Ports.proj]

I noticed the runtime.linux-x64.runtime.native.System.IO.Ports.proj project was recently changed to <IsPackable>true</IsPackable> with 85441ce.

Note: this should be caught at the repo level once #54573 is implemented.

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The runtime repo is failing to source build.

./build.sh -c Release --restore --build --pack /p:ArcadeBuildFromSource=true -bl

/repos/runtime/.dotnet/sdk/6.0.100-rc.1.21411.28/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5026: The file '/repos/runtime/artifacts/source-build/self/src/artifacts/bin/native/net6.0-Linux-Release-x64/libSystem.IO.Ports.Native.so.dbg' to be packed was not found on disk. [/repos/runtime/artifacts/source-build/self/src/src/libraries/System.IO.Ports/pkg/runtime.linux-x64.runtime.native.System.IO.Ports.proj]

I noticed the runtime.linux-x64.runtime.native.System.IO.Ports.proj project was recently changed to <IsPackable>true</IsPackable> with 85441ce.

Note: this should be caught at the repo level once #54573 is implemented.

Author:	MichaelSimons
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

[MichaelSimons]

cc @ViktorHofer

[ViktorHofer]

The file '/repos/runtime/artifacts/source-build/self/src/artifacts/bin/native/net6.0-Linux-Release-x64/libSystem.IO.Ports.Native.so.dbg' to be packed was not found on disk

Are native assets and/or symbols not built during source build?

Do you have a binlog or can you post what ls -la /repos/runtime/artifacts/source-build/self/src/artifacts/bin/native/net6.0-Linux-Release-x64/ prints? Would like to understand why the native symbol file is missing.

[MichaelSimons]

I apologize, I intended to include a binlog. Here is a link to one (Microsoft internal link) - https://devdiv.visualstudio.com/DefaultCollection/Personal/_git/msimons?path=%2Fissue-notes%2Fruntime.issue-58455.sourcebuild.binlog

Native assets are built. For example '/repos/runtime/artifacts/source-build/self/src/artifacts/bin/native/net6.0-Linux-Release-x64/libSystem.IO.Ports.Native.so' is produced by the build. I'm not seeing symbols. @dseefeld, @crummel - Should source-build be producing symbols?

[ViktorHofer]

cc @dseefeld @crummel. This sounds like sourcebuild isn't producing the expected symbols. As we aren't hitting this in normal CI builds I would imagine there's an unexpected difference in behavior when building from source.

[MichaelSimons]

Source build is setting keepNativeSymbols=true here. This setting prevents the symbols from being stripped out and placed into a separate .dbg file. Here is some context on this behavior. When I build source-build without this setting the build error does not occur.

To support this, should this pack code be modified to respect the keepNativeSymbols setting and skip packing symbols?

[ViktorHofer]

Got it. So in that case, you want to modify this line to only apply if $(keepNativeSymbols) isn't true:

runtime/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props

Line 11 in 9bdd292

<TargetsForTfmSpecificDebugSymbolsInPackage>$(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage</TargetsForTfmSpecificDebugSymbolsInPackage>

[ViktorHofer]

Do you want to submit a fix or should I?

[MichaelSimons]

I just finished testing the fix and will submit a PR. Thanks for the help on this @ViktorHofer!