OdbcConnection.ServerVersion may return null but docs says it will throw or return "" instead

[krwq]

See docs: https://docs.microsoft.com/en-us/dotnet/api/system.data.odbc.odbcconnection.serverversion?view=dotnet-plat-ext-3.1

but implementation OdbcConnectionOpen.ServerVersion will return null in some cases.

Either docs or implementation should be fixed here.

Found when applying nullable annotations

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

[roji]

Yeah, I ran across this during annotation: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionOpen.cs#L35 (based on #689).

[krwq]

Yes, this is based on your comment, I'll be removing TODO-NULLABLEs or replacing them with issues or fixing in a PR soon

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

[dotnet-policy-service]

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.