HttpHandlerDiagnosticListener did not send DiagnosticSource Ex.Stop event on netfx in W3C mode #40777

[eduard-bystrov]

see dotnet/corefx#40777 first

forgot to fix for Ex.Stop ? or I'm wrong

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/HttpHandlerDiagnosticListener.cs

Line 674 in 037e7fc

if (request.Headers.Get(RequestIdHeaderName) != null && IsLastResponse(request, statusCode))

---

and second question.
Request with status code 401(Unauthorized) can be autoredirected, which leads to the execution of the second request on the same object HttpWebRequest.

If this happens we have the following chain of events:

1. System.Net.Http.Desktop.HttpRequestOut.Start
2. System.Net.Http.Desktop.HttpRequestOut.Ex.Stop (got 401)
3. System.Net.Http.Desktop.HttpRequestOut.Stop (success)

it's a bit strange... hardly anyone expects to get Stop and Stop.Ex for one request.

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

Tagging subscribers to this area: @tommcdon, @krwq
Notify danmosemsft if you want to be subscribed.

[tommcdon]

@noahfalk

[noahfalk]

forgot to fix for Ex.Stop ? or I'm wrong

Yeah it does appear that the fix was incomplete. Thanks for filing the issue! If you are interested in submitting the PR to fix it I'd be happy to review it, otherwise we can leave this until someone else can get to it (which could be a while).

and second question... Request with status code 401(Unauthorized)

I'm not sure what the question was, were you asking if the behavior is intentional? I'm not the original author so I can't say for sure but if I had to guess it probably is emergent behavior rather than intentional. If you wanted to propose a change in behavior or have more discussion about it lets open a 2nd issue to ensure we keep track of both.

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.