Test failure: JIT\\Regression\\JitBlue\\GitHub_35821\\GitHub_35821\\GitHub_35821.cmd

[v-haren]

failed in job: runtime-coreclr jitstress-isas-arm 20200509.1

Error message

Assert failure(PID 19192 [0x00004af8], Thread: 18764 [0x494c]): Assertion failed 'varTypeIsFloating(tree->TypeGet())' in 'projs.GitHub_35821:Main(System.String[]):int' during 'Assertion prop' (IL size 48)

 File: F:\workspace\_work\1\s\src\coreclr\src\jit\assertionprop.cpp Line: 2434
 Image: C:\h\w\AF270949\p\CoreRun.exe


Return code: 1
Raw output file: C:\h\w\AF270949\w\A48408EF\e\JIT\Regression\Reports\JIT.Regression\JitBlue\GitHub_35821\GitHub_35821\GitHub_35821.output.txt
Raw output:
BEGIN EXECUTION
 "C:\h\w\AF270949\p\corerun.exe" GitHub_35821.dll 
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=C:\h\w\AF270949\p
> C:\h\w\AF270949\w\A48408EF\e\JIT\Regression\JitBlue\GitHub_35821\GitHub_35821\GitHub_35821.cmd
Expected: True
Actual: False


Stack trace
   at JIT_Regression._JitBlue_GitHub_35821_GitHub_35821_GitHub_35821_._JitBlue_GitHub_35821_GitHub_35821_GitHub_35821_cmd() in F:\workspace\_work\1\s\artifacts\tests\coreclr\Windows_NT.arm64.Checked\TestWrappers\JIT.Regression\JIT.Regression.XUnitWrapper.cs:line 124106

[BruceForstall]

From CoreCLR Windows_NT arm64 Checked jitstress_isas_nohwintrinsic_nosimd,

set COMPlus_TieredCompilation=0
set COMPlus_EnableHWIntrinsic=0
set COMPlus_FeatureSIMD=0

@echesakovMSFT @kunalspathak @tannergooding @CarolEidt

[kunalspathak]

I will take a look. This is the new test that I added last week.

[kunalspathak]

I believe this is an existing issue that got exposed because of this test case. The C# version of the test is simple. We just need to create Vector64.Create(double_imm) and pass it to method.

Test3(Vector64.Create(23.1));
		
[MethodImpl(MethodImplOptions.NoInlining)]
public static void Test3(Vector64<double> data) {}

This repros only if COMPlus_FeatureSIMD=0. With that, we inline Vector64.Create(double value) implementation which is Unsafe.As() as seen here. Then we try to constant propagate the value of double in assertion prop. But when we try to do it same for the tree node that represents the result, we hit assert here because tree->TypeGet() == TYP_SIMD8. I think the right fix would be to not do constant propagation in such case. I didn't see an easy way to repro it for other types like TYP_SIMD16, etc. because we might not inline the implementation of Vector128.Create(double).

@briansull , @BruceForstall - can one of you confirm my understanding?
@tannergooding - I assume that even you would hit this in your #36267.

[CarolEidt]

I believe that the fundamental problem here is the retyping that we do of TYP_SIMD8 return types as TYP_DOUBLE. I believe that the right answer here is to never retype TYP_SIMD return values as TYP_DOUBLE, just as we're moving away from retyping other struct return types. I think @sandreenko might also want to comment here.

[sandreenko]

The issue should be resolved with JitDoOldStructRetyping = false, I will check that once I finish support for arm32.

Thanks for the analysis.