Add benchmarks for Zip entry extraction and creation - #1781
Conversation
| ZipFile.CreateFromDirectory(currentTestFolderLocation, _archiveLocation, CompressionLevel, includeBaseDirectory: false); | ||
| _archive = ZipFile.OpenRead(_archiveLocation); | ||
| _entry = _archive.Entries[0]; | ||
| _tempDestinationFileName = FileUtils.GetTestFilePath(); |
There was a problem hiding this comment.
Please let me know if this is the right way of getting a temporarily file name for concurrent writes/deletes. In long runs I was always getting the error "access to the path is denied"; by long runs I mean this command:
dotnet run -c Release -f net6.0
--filter *ExtractEntryToFile* --statisticalTest 3ms
--coreRun
"C:\repos\runtime2\artifacts\bin\testhost\net6.0-windows-Release-x64\shared\Microsoft.NETCore.App\6.0.0\CoreRun.exe"
"C:\repos\runtime\artifacts\bin\testhost\net6.0-windows-Release-x64\shared\Microsoft.NETCore.App\6.0.0\CoreRun.exe"
--maxIterationCount 101 --minIterationCount 100
There was a problem hiding this comment.
@adamsitnik there was another argument you used, but I can't find it. Do you remember what was it? Should David use it here too?
Edit: Found it. It was this argument: no outliers removal (--outliers DontRemove).
There was a problem hiding this comment.
ping @adamsitnik this was so long ago that I don't remember the context of the argument I mentioned 😄
jozkee
changed the title
|
@jozkee @carlossanlop what is the status of this PR? |
|
@carlossanlop @jozkee is this dead or alive 😸 |
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
The code looks good to me, modulo the question about how to properly open the file to ensure we don't see the error. Help us @adamsitnik, you're our only hope.
3 participants
cc @adamsitnik @carlossanlop