Skip to content

Remove orphaned analyzer dependencies and version properties - #7790

Open
svick wants to merge 2 commits into
dotnet:mainfrom
svick:reference-cleanup
Open

svick wants to merge 2 commits into
dotnet:mainfrom
svick:reference-cleanup

Conversation

@svick

@svick svick commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #7785: remove additional orphaned references found during dependency audit.

  • Remove Microsoft.CSharp and System.Formats.Asn1 from Microsoft.ML.InternalCodeAnalyzer, together with their central package declarations and version properties. The analyzer does not use their APIs, and neither package is required by its remaining dependency graph.
  • Remove the unused MicrosoftCodeAnalysisCSharpInternalAnalyzerVersion and TensorFlowMajorVersion properties.
  • Preserve active transitive version pins and the intentionally retained CUDA test configuration.

Validation

Verified that neither removed package remains in the restored analyzer or analyzer-test dependency graph.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2fb770b3-3674-4921-83ab-16f9ba562647

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All removed declarations are unused, and retained dependencies remain consistently versioned.

0 open findings

What changed in this PR

Removes unused analyzer dependencies and orphaned central version properties.

Changes:

  • Removes two unused analyzer package references.
  • Cleans up corresponding package declarations and version properties.
File Description
tools-local/​Microsoft.ML.InternalCodeAnalyzer/​Microsoft.ML.InternalCodeAnalyzer.csproj Removes unused dependencies.
Directory.Packages.props Removes orphaned package declarations.
eng/​Versions.props Removes unused version properties.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.85%. Comparing base (7d1d179) to head (540ee90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7790      +/-   ##
==========================================
+ Coverage   70.84%   70.85%   +0.01%     
==========================================
  Files        1420     1420              
  Lines      279991   279991              
  Branches    27594    27594              
==========================================
+ Hits       198373   198401      +28     
+ Misses      73475    73446      -29     
- Partials     8143     8144       +1     
Flag Coverage Δ
Debug 70.85% <ø> (+0.01%) ⬆️
production 64.31% <ø> (+0.01%) ⬆️
test 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svick
svick marked this pull request as ready for review November 9, 2026 12:38
@svick
svick requested a review from rosebyte November 9, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants