Skip to content

Fix PositiveRecall optimization in AutoMLExperiment - #7493

Merged
ericstj merged 2 commits into
dotnet:mainfrom
JoshuaSloan:main
Oct 22, 2025
Merged

ericstj merged 2 commits into
dotnet:mainfrom
JoshuaSloan:main

Conversation

@JoshuaSloan

Copy link
Copy Markdown
Contributor

BinaryClassificationMetric.PositiveRecall incorrectly returns PositivePrecision.

I noticed this when testing an early stopping pipeline and found that the logged best trial metric did not align with the final model results. This is a self-evident fix (akin to a small typo), so I did not open a new issue for it.

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Pull requests submitted by community contributors label Aug 7, 2025
@codecov

codecov Bot commented Aug 7, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.08%. Comparing base (fb39755) to head (93f5392).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...osoft.ML.AutoML/AutoMLExperiment/IMetricManager.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7493      +/-   ##
==========================================
+ Coverage   69.01%   69.08%   +0.07%     
==========================================
  Files        1482     1482              
  Lines      273999   274619     +620     
  Branches    28258    28459     +201     
==========================================
+ Hits       189093   189726     +633     
+ Misses      77520    77512       -8     
+ Partials     7386     7381       -5     
Flag Coverage Δ
Debug 69.08% <0.00%> (+0.07%) ⬆️
production 63.38% <0.00%> (+0.07%) ⬆️
test 89.51% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...osoft.ML.AutoML/AutoMLExperiment/IMetricManager.cs 51.76% <0.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj

ericstj commented Oct 1, 2025

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@ericstj
ericstj merged commit c100606 into dotnet:main Oct 22, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Pull requests submitted by community contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants