Skip to content

Testing out the assert we are hitting on ARM - #6922

Closed
ericstj wants to merge 4 commits into
dotnet:mainfrom
ericstj:testArmAssert
Closed

ericstj wants to merge 4 commits into
dotnet:mainfrom
ericstj:testArmAssert

Conversation

@ericstj

@ericstj ericstj commented Dec 21, 2023

Copy link
Copy Markdown
Member

No description provided.

Asserting on `_rowCount <  Utils.Size(_valueBoundaries)` was catching a
case where `_rowCount`'s update was reordered before `_valueBoundaries`

This was unnecessary, since this method doesn't need to use `_rowCount`.

Instead, make the asserts use only `idx` which will be maintained
consistent with the waiter logic in this cache.
�Ensure we only ever use `_rowCount` from the caching thread, so write
reordering won't matter.
@ericstj

ericstj commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

Looks like this worked - didn't assert on idx. Will rebase and submit a real PR.

@ericstj ericstj closed this Dec 21, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant