Skip to content

Include the save file action (.ZIP file) as part of model.SaveFile(). - #2993

Merged
codemzs merged 3 commits into
dotnet:masterfrom
codemzs:saveapi
Mar 19, 2019
Merged

codemzs merged 3 commits into
dotnet:masterfrom
codemzs:saveapi

Conversation

@codemzs

@codemzs codemzs commented Mar 18, 2019

Copy link
Copy Markdown
Member

fixes #1689

@codecov

codecov Bot commented Mar 18, 2019 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@02524a7). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2993   +/-   ##
=========================================
  Coverage          ?   72.28%           
=========================================
  Files             ?      796           
  Lines             ?   142352           
  Branches          ?    16051           
=========================================
  Hits              ?   102893           
  Misses            ?    35075           
  Partials          ?     4384
Flag Coverage Δ
#Debug 72.28% <100%> (?)
#production 67.99% <100%> (?)
#test 88.48% <100%> (?)
Impacted Files Coverage Δ
.../Microsoft.ML.Data/Model/ModelOperationsCatalog.cs 100% <100%> (ø)
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 73.64% <100%> (ø)
#Resolved

@TomFinley TomFinley left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codemzs , thanks for looking at this. This appears to not be consistent with our discussion and thinking in #2858. Could you comment on this? ccing @yaeldekel

@TomFinley TomFinley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for adjusting it @codemzs !!

@codemzs
codemzs merged commit 8ed72fb into dotnet:master Mar 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include the "save file" action (.ZIP file) as part of model.SaveFile()

3 participants